Fix for Android notification actions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs that clear the activity stack as is the case with launch intent.
k00na
requested review from
LinusU,
acanturgut,
albinekb,
mathisfouques and
MrAlek
MrAlek
reviewed
Apr 28, 2020
| @@ -409,11 +408,20 @@ class CallKeep(private val channel: MethodChannel, private var applicationContex | |||
| launchIntent.putExtra(key, value) | |||
| } | |||
|
|
|||
| var answerIntent = Intent(launchIntent) | |||
There was a problem hiding this comment.
After this, is the launchIntent still needed? I don't really understand this PendingIntent below.
There was a problem hiding this comment.
Yes, launchIntent gets triggered when the user clicks on the notification itself and not on the actions. When notification is clicked it gets expanded to the full screen activity for the incoming call.
MrAlek
approved these changes
Apr 28, 2020
This was referenced Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed launch intent from decline and answer actions. Before this, clicking one of the notification actions would unnecessarily restart the app in cases when it was already running.