Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add requirement for android #11

Conversation

yukitaka13-1110
Copy link
Contributor

HI!
I have added the required permissions for Android to README.md because there was so little information about the required permissions.
I believe that this change will bring good results to many people.

@MrAlek
Copy link
Contributor

MrAlek commented Apr 29, 2020

Great initiative @yukitaka13-1110!

Should be noted that some of these permissions are only needed when using ConnectionService (displayIncomingCall).

When using displayCustomIncomingCall you need USE_FULL_SCREEN_INTENT.

@yukitaka13-1110
Copy link
Contributor Author

@MrAlek Thank you!
That's important information, for sure.
Will it be okay if I fix it?

@MrAlek
Copy link
Contributor

MrAlek commented Apr 29, 2020

@yukitaka13-1110 Absolutely, thanks for the fast response!

@yukitaka13-1110
Copy link
Contributor Author

@MrAlek
All right. I will fix it.

…ayIncomingCall and displayCustomIncomingCall
@yukitaka13-1110
Copy link
Contributor Author

yukitaka13-1110 commented Apr 29, 2020

@MrAlek Would you please check commit?
Please let me know if I need to modify it.

@MrAlek MrAlek self-requested a review April 29, 2020 15:56
Copy link
Contributor

@MrAlek MrAlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution 👍

@MrAlek MrAlek merged commit 96fdf43 into doneservices:master Apr 29, 2020
@yukitaka13-1110 yukitaka13-1110 deleted the doc/add_required_permission_for_android branch April 29, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants