Reboot support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legacy code is still active for legacy repositories, the reboot uses UBT, UAT and least possible of msbuild/xbuild. Let UAT BuildCommonTools handle compilation for tricky csproj configs, and new targets were added (LiveCodingConsole).
poppolopoppo
commented
Nov 8, 2019
| def _ue4_run_ubt(env, target, build_platform, build_configuration, vs_version=None, flags=None): | ||
| if nimp.sys.platform.is_windows(): | ||
| command = ['cmd', '/c', 'Build.bat'] | ||
| command = ['cmd', '/c', 'Engine\\Build\\BatchFiles\\Build.bat'] |
There was a problem hiding this comment.
En pcipe cwd tape dans root_dir, donc /game et pas /ue4 (qui est dans ue4_dir), il me semble que le path ne vas pas être bon ?
nimp/ue4/build.py
Outdated
| _ue4_build_ps4_tools_workaround(env, solution, vs_version) | ||
|
|
||
| # this is DNE specific | ||
| if os.path.exists(nimp.system.sanitize_path(env.format('{root_dir}/Engine/Source/Programs/DNEAssetRegistryQuery/DNEAssetRegistryQuery.Build.cs'))): |
There was a problem hiding this comment.
Du coup ce path est faux aussi, mon mauvais :/ ça devrait être qq chose comme root_dir/tools/dneassetregistry, en même temps le projet n'est pas encore importé ^^;
Prefer {ue4_dir} instead of {root_dir},
And use Engine/* paths instead of Game/* specific aliases to DNE reboot.
Also run prebuild after GenerateProjetFiles.bat for >= ue4.22.
poppolopoppo
force-pushed
the
reboot_support
branch
from
f70328c
to
633d964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow building the rebooted Unreal repository :
env.ue4_dirinstead ofenv.root_dirSupport for legacy repositories should be intact (diverging with
env.is_dne_legacy_ue4).