This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
fix Dockerfile, lsp warning and preserve_edit_pos #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete packer_compiled.lua: this should not be commited! Signed-off-by: Edwin Török <edwin@etorok.net>
Delete dead code Signed-off-by: Edwin Török <edwin@etorok.net>
When rebasing / bisecting / etc. the worktree would be in a detached HEAD state. Do not checkout the branch because this would unexpectedly move the currently checked out commit. Especially important if we want to compare performance one-by-one by rebasing in edit mode. Signed-off-by: Edwin Török <edwin@etorok.net>
pacman was stopping and asking a question, needs noconfirm flag. Directories mounted as volumes need to be created on first use. 'make' needs to be installed otherwise nvim-treesitter fails to compile the treesitter parsers and hangs at 'Compiling' (sync_install=true can be used to show actual error). Signed-off-by: Edwin Török <edwin@etorok.net>
…base buffers See ':h last-position-jump' The commit message will likely be different each time, although the filename will be the same (`COMMIT_EDITMSG`). Signed-off-by: Edwin Török <edwin@etorok.net>
Use the vim.diagnostic API instead, see :h deprecated. Otherwise a message is printed on every use that they are deprecated. Signed-off-by: Edwin Török <edwin@etorok.net>
|
Just tested it all out, works great! Thank you for the PR and for cleaning up some of my mistakes. I am currently still tidying the project up. v4.x still has some rough edges but I figured it'd be more stable than 3.x at this point. |
molleweide
added a commit
to molleweide/doom-nvim
that referenced
this pull request
Aug 8, 2022
* main: (73 commits) refactor(settings): move settings table into root chore: format source code fix(explorer): avoid startup warning about unknown option fix(explorer): load when editing dir fix(netrw): do not disable loading netrw when netrw feature is enabled feat(langs,dockerfile): Added Dockerfile language support. chore: format source code feat(lsp): Enabled ghost_text by default chore(docs): Removed references to deprecated `develop` branch. chore: format source code feat(langs,ocaml): add language (doom-neovim#373) chore: format source code fix(docker,lsp,core): Dockerfile, lsp warning and preserve_edit_pos (doom-neovim#371) fix(linter): Increased formatting timeout. fix(lsp): Broken snippet options refact(langs): Renamed `snippets` to `extra_snippets`. fix(lsp): Fixed some lsps not working when `snippets` module disabled. chore(deps): Update pinned packer dependencies feat(docs): Added uninstall docs fix(logger): Fix when `stdpath('data')` doesn't exist @dwarfmaster doom-neovim#364 ...
molleweide
added a commit
to molleweide/doom-nvim
that referenced
this pull request
Aug 9, 2022
* molleweide: (92 commits) markdown_tools add plugin refactor(settings): move settings table into root chore: format source code fix(explorer): avoid startup warning about unknown option fix(explorer): load when editing dir fix(netrw): do not disable loading netrw when netrw feature is enabled fix(git): small fix + formatting moonfly theme add more modules incluing ruby feat(langs,dockerfile): Added Dockerfile language support. chore: format source code feat(lsp): Enabled ghost_text by default chore(docs): Removed references to deprecated `develop` branch. chore: format source code feat(langs,ocaml): add language (doom-neovim#373) chore: format source code fix(docker,lsp,core): Dockerfile, lsp warning and preserve_edit_pos (doom-neovim#371) fix(linter): Increased formatting timeout. fix(lsp): Broken snippet options refact(langs): Renamed `snippets` to `extra_snippets`. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to upstream some local changes I had on top of Doom-nvim.
I'm updating them to v4.0.1 and will try to upstream them, grouping related commits into same PR.
This PR is for some fixes I've done to the
tools/, mostly the Dockerfile, and 2 small bugfixes to Doom-nvim.The fixes have been tested using the tools/start_docker.sh