Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have bug with doom-buffer-mode and icons neotree #39

Closed
honnisha opened this issue Feb 19, 2017 · 6 comments
Closed

I have bug with doom-buffer-mode and icons neotree #39

honnisha opened this issue Feb 19, 2017 · 6 comments

Comments

@honnisha
Copy link

I have two bugs or I use something wrong.

First with this part: when I move between my frames, "doom-buffer-mode" is not change.

  ;; brighter source buffers
  (add-hook 'find-file-hook 'doom-buffer-mode)
  ;; brighter minibuffer when active
  (add-hook 'minibuffer-setup-hook 'doom-brighten-minibuffer)
  ;; The temporary buffers ediff spins up aren't dimmed. You can fix this with:
  (add-hook 'ediff-prepare-buffer-hook 'doom-buffer-mode)

Second with neotree: something's wrong with the icons:
12

@hlissner
Copy link
Member

About neotree:

Have you installed the fonts provided by all-the-icons? This is required to use their icons.

About doom-buffer-mode, that is strange. Could you provide a list of steps to reproduce that?

@honnisha
Copy link
Author

Have you installed the fonts provided by all-the-icons? This is required to use their icons.

Yes, but I have symbols instead icons, its not important because its most likely all-the-icons issue.

screenshot_20170221_190501

About doom-buffer-mode, that is strange. Could you provide a list of steps to reproduce that?

doom-buffer-mode work well if I use it trough M-x. New created buffers created with doom-buffer-mode (not always), darker than others, but when i switch between buffers nothing changes.

This is my settings:

(use-package doom-themes
  :ensure t
  :config
  (setq doom-neotree-enable-file-icons t)
  (load-theme 'doom-one t) ;; or doom-dark, etc.
  (setq doom-enable-bold t    ; if nil, bolding are universally disabled
	doom-enable-italic t  ; if nil, italics are universally disabled

	doom-one-brighter-modeline nil
	doom-one-brighter-comments nil
	)
  ;; brighter source buffers
  (add-hook 'find-file-hook 'doom-buffer-mode)
  ;; brighter minibuffer when active
  (add-hook 'minibuffer-setup-hook 'doom-brighten-minibuffer)
  ;; The temporary buffers ediff spins up aren't dimmed. You can fix this with:
  (add-hook 'ediff-prepare-buffer-hook 'doom-buffer-mode)
  
  ;; Enable custom neotree theme
  (require 'doom-neotree)    ; all-the-icons fonts must be installed!
  ;; Enable nlinum line highlighting
  (require 'doom-nlinum)     ; requires nlinum and hl-line-mode
  )

@hlissner
Copy link
Member

hlissner commented Feb 22, 2017

This is strange. It is possible that an error is occuring before doom-buffer-mode gets run. You may want to check view-echo-area-messages to see if there are any error messages (coming from another part of your emacs config).

If there aren't any, here is an alternative solution that works for me:

  (defun doom*brighter-buffer-maybe (buffer &rest _)
    (when (and (not doom-buffer-mode)
               buffer-file-name)
      (doom-buffer-mode +1)))
  (advice-add 'switch-to-buffer :after 'doom*brighter-buffer-maybe)
  (advice-add 'display-buffer   :after 'doom*brighter-buffer-maybe)

You do not need (add-hook 'find-file-hook 'doom-buffer-mode) with this.

Let me know if that solves your problem.


As for neotree, I don't think it's a neotree issue. I am using doom-themes neotree mod (on Arch Linux) and it works fine. From the screenshot, it looks like it's not recognizing the fonts.

@hlissner
Copy link
Member

Whoops, ignore that doom-popup-p call in the above code. That's only for my emacs.d. I've corrected it now.

@honnisha
Copy link
Author

honnisha commented Feb 22, 2017

Nothing changes with doom*brighter-buffer-maybe. Nothing in Messages buffer.

Its strange, because doom-buffer-mode work as well trough M-x, but (add-hook 'find-file-hook 'doom-buffer-mode) doesn't work at all. How can I test add-hook 'find-file-hook? I don't know how to use elisp.

@honnisha
Copy link
Author

honnisha commented Apr 1, 2017

I tried on computer and on my laptop. Both are use Kubuntu, the result is the same.I tried to leave only the doom-themes settings in .emacs, it still doesn't work. Any clues?

p.s.
I start use https://github.com/mina86/auto-dim-other-buffers.el instead doom-buffer-mode, works for me.

@honnisha honnisha closed this as completed Apr 2, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants