Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde_bytes to serialize Vec<u8> #336

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Use serde_bytes to serialize Vec<u8> #336

merged 1 commit into from
Aug 11, 2023

Conversation

haixuanTao
Copy link
Collaborator

Seializing Vec by default iterate over each element instead of copying the byte array.

See: rust-lang/rust#31844

Seializing Vec<u8> by default iterate over each element instead of copying
the byte array.

See: rust-lang/rust#31844
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@phil-opp phil-opp merged commit 56ec38f into main Aug 11, 2023
29 checks passed
@phil-opp phil-opp deleted the serde_bytes branch August 11, 2023 12:44
@haixuanTao haixuanTao mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants