Add an error catch in python on_event when using hot-reloading
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this includes the commits from #382 now. Was this intended? |
haixuanTao
force-pushed
the
allow-error-in-hot-reload-env
branch
from
1272f27
to
5bff656
Compare
|
Made a typo in the error handling that's why I did not merged it yet. I also removed the unwanted commit. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we introduce a bug within the
on_eventfunction during hot-reloading event. The whole dataflow is going to stop because we're not catching the error. With the PR we'll allow errors and just warn the user.