Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature XCUITest #780

Merged
merged 2 commits into from
Jan 22, 2024
Merged

add feature XCUITest #780

merged 2 commits into from
Jan 22, 2024

Conversation

codeskyblue
Copy link
Contributor

No description provided.

This was referenced Jan 12, 2024
Closed
Open
@codeskyblue
Copy link
Contributor Author

Are there any codes that need me to update?

doronz88
doronz88 requested changes Jan 16, 2024
View reviewed changes
Copy link
Owner

@doronz88 doronz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the apps lookup issue

pymobiledevice3/cli/developer.py Outdated
@@ -271,6 +277,32 @@ def screenshot(service_provider: LockdownClient, out):
out.write(Screenshot(dvt).get_screenshot())


def app_lookup(install_service: InstallationProxyService, bundle_id: str):
# TODO: install_service.lookup is not working for RSD，use browse instead
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase on master. i added a bundle_identifiers keyword for that which also should be much faster

@codeskyblue
Copy link
Contributor Author

done @doronz88

doronz88
doronz88 requested changes Jan 16, 2024
View reviewed changes
Copy link
Owner

@doronz88 doronz88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase the commits to contain:

  • process_control: add extra_options to launch()
  • developer: add xcuitest support

if you're having trouble with git rebase, i can do it myself, but then the commit author will change to me and I want you to have the credit on it :)

@doronz88
Copy link
Owner

@codeskyblue I meant for the two commits to be separate. One for modifying the process_control and the other for the rest - Splitting the two commits into 2 logical units

@doronz88 doronz88 merged commit 57aa99e into doronz88:master Jan 22, 2024
16 checks passed
@doronz88
Copy link
Owner

merged! thanks for you contribution :)

@krishtoautomate
Copy link

krishtoautomate commented Feb 16, 2024 •
edited
Loading

how to test this?

I tried with :
python3 -m pymobiledevice3 developer dvt xcuitest RDSRunner.xctrunner --rsd fd90:609e:8a9f::1 54232

but not able to access http://DEVICE_IP:8100/status

@codeskyblue
Copy link
Contributor Author

@krishtoautomate yes, it is not working for iOS17 now.

@corrrso
Copy link

corrrso commented Mar 20, 2024

Hello @codeskyblue , Are there any plans to make this work with iOS17?

@codeskyblue
Copy link
Contributor Author

Hello @codeskyblue , Are there any plans to make this work with iOS17?

No plans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronz88 doronz88 doronz88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codeskyblue @doronz88 @krishtoautomate @corrrso