Skip files that raise RecursionError
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain deeply-nested expressions cause the Refurb visitor to blow the stack. This doesn't seem to be an issue when running with Mypy directly, though this is probably because we are traversing the entire AST. As a workaround we will silently ignore files that cause this issue. For debugging purposes there should probably be a flag to show files that have been ignored (perhaps just stuff it under the `-v` flag for now). Also bump version for new release. Closes #302.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain deeply-nested expressions cause the Refurb visitor to blow the stack. This doesn't seem to be an issue when running with Mypy directly, though this is probably because we are traversing the entire AST. As a workaround we will silently ignore files that cause this issue. For debugging purposes there should probably be a flag to show files that have been ignored (perhaps just stuff it under the
-vflag for now).Also bump version for new release.
Closes #302.