Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic/#1 icd10 api #5

Merged
merged 27 commits into from
Aug 28, 2020
Merged

Epic/#1 icd10 api #5

merged 27 commits into from
Aug 28, 2020

Conversation

andreakreichgauer
Copy link
Contributor

@andreakreichgauer andreakreichgauer commented Aug 18, 2020 •
edited
Loading

First API version for searching conditions based on the ICD10gm terminology.

Includes the following:

  • fuzzy search
  • processing of icd.json as FHIR Codesystem
  • search for matches in icd-field description but also nested field inclusion
  • icd-code based and text search
  • searching for multiple terms - and their combinations / regardless of their order

Does not yet include:

  • a convenient scoring and ranking of matches

This closes #3 and closes #2

This was linked to issues Aug 18, 2020
ICD-10 API: implement search algorithm #2
Closed
ICD-10 API: processing base data (icd10-gm.json) #3
Closed
@friedow friedow added Priority: Medium Medium priority issue. Status: Review Needed Please review the corresponding code. Type: Story An improvement to the project from a user's perspective. Type: Epic Bigger project goal that encloses multiple user stories. and removed Type: Story An improvement to the project from a user's perspective. labels Aug 19, 2020
@friedow
Copy link
Contributor

friedow commented Aug 19, 2020 •
edited
Loading

This closes #3 and closes #2.

friedow
friedow suggested changes Aug 19, 2020
View reviewed changes
src/server.ts Outdated Show resolved Hide resolved
src/model/ICD10gmCodesystem.ts Outdated Show resolved Hide resolved
src/model/ICD10gmCodesystem.ts Outdated Show resolved Hide resolved
src/model/ICD10gmCodesystem.ts Outdated Show resolved Hide resolved
src/model/ICD10gmCodesystem.ts Outdated Show resolved Hide resolved
src/services/filter.ts Outdated Show resolved Hide resolved
src/services/filter.ts Outdated Show resolved Hide resolved
src/services/filter.ts Outdated Show resolved Hide resolved
src/services/filter.ts Outdated Show resolved Hide resolved
src/services/textFilter.ts Show resolved Hide resolved
@friedow friedow added Status: Revision Needed Something that needs to be overhauled. and removed Status: Review Needed Please review the corresponding code. Priority: Medium Medium priority issue. Status: Revision Needed Something that needs to be overhauled. Type: Epic Bigger project goal that encloses multiple user stories. labels Aug 20, 2020
friedow
friedow suggested changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@friedow friedow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely refactored :)! Only some style things left ;).

src/model/ICD10gmCodesystem.ts Outdated Show resolved Hide resolved
src/model/ICD10gmCodesystem.ts Outdated Show resolved Hide resolved
src/model/ICD10gmCodesystem.ts Outdated Show resolved Hide resolved
src/model/ICD10gmCodesystem.ts Outdated Show resolved Hide resolved
src/model/ICD10gmCodesystem.ts Outdated Show resolved Hide resolved
src/services/filter.ts Outdated Show resolved Hide resolved
src/services/codeFilter.ts Outdated Show resolved Hide resolved
src/services/fuseSearch.ts Show resolved Hide resolved
src/services/fuseSearch.ts Outdated Show resolved Hide resolved
src/services/textFilter.ts Outdated Show resolved Hide resolved
friedow
friedow previously approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@friedow friedow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 👍!

@andreakreichgauer andreakreichgauer changed the base branch from master to dev August 28, 2020 09:50
andreakreichgauer and others added 21 commits August 28, 2020 11:53
@andreakreichgauer
typo in filename
7cfabca
@andreakreichgauer
refactoring - changed static to instance based context
3be294d
@andreakreichgauer
typed queryOptions to merge different getQuery methods into one generic
66f175e
@andreakreichgauer
refactored prefiltering Codesystem for TextSearch
58849b0 
use extension/modifierExtension as stripped key fields for searching
@andreakreichgauer
added singleton and error handling to icd10 init and preprocessing
f84d688
@andreakreichgauer
updated imports
55fed02
@andreakreichgauer
splitted codesystem preprocessing into several methods
fcc2190
@andreakreichgauer
updated for-loop syntax
0c71798
@andreakreichgauer
refactored pattern
0d2a1e2 
removed "pseudo"-factory and used static context instead
@andreakreichgauer
changed icdController to static context
7c53345
@andreakreichgauer
minor changes from review request
ac83c0e
@andreakreichgauer @friedow
Update src/services/codeFilter.ts
53de7f7 
Co-authored-by: Christian Friedow <christian@friedow.com>
@andreakreichgauer @friedow
Update src/model/ICD10gmCodesystem.ts
1e441cd 
Co-authored-by: Christian Friedow <christian@friedow.com>
@andreakreichgauer @friedow
Update src/services/fuseSearch.ts
8b571cb 
Co-authored-by: Christian Friedow <christian@friedow.com>
@andreakreichgauer @friedow
Update src/services/fuseSearch.ts
3c84412 
Co-authored-by: Christian Friedow <christian@friedow.com>
@andreakreichgauer
cleaned up imports
25d08c5
@andreakreichgauer
changed methods to be static
10d7665
@andreakreichgauer
minor code cleanup
336edeb
@andreakreichgauer
add comment on setQueryString for readibility
b35eed6
@andreakreichgauer
Revert "add comment on setQueryString for readibility"
3449cae 
This reverts commit 370dea1.
@andreakreichgauer
add some codestyling , comment and eslint-disable
23708aa
@andreakreichgauer andreakreichgauer merged commit e98ec93 into dev Aug 28, 2020
@andreakreichgauer andreakreichgauer deleted the epic/#1-ICD10-API branch August 28, 2020 09:54
This was referenced Aug 28, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedow friedow friedow approved these changes

Assignees

@andreakreichgauer andreakreichgauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICD-10 API: processing base data (icd10-gm.json) ICD-10 API: implement search algorithm
2 participants
@andreakreichgauer @friedow