Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] : GIF files not showing up correctly in the backend #19338

Closed
jcastro-dotcms opened this issue Sep 25, 2020 · 7 comments
Closed

[core] : GIF files not showing up correctly in the backend #19338

jcastro-dotcms opened this issue Sep 25, 2020 · 7 comments
Labels
dotCMS : Content Management Merged QA : Approved QA : Passed Internal Release : 20.10.1 Type : Defect

Comments

@jcastro-dotcms
Copy link
Contributor

jcastro-dotcms commented Sep 25, 2020 •
edited
Loading

Reported via Support: 102410
Reproducible in dotCMS 5.3.4, our Demo Site (5.3.8 and 5.3.9), and latest master.

Describe the bug
GIF files are a supported image format in dotCMS. However, such file types are not being displayed correctly in specific portlets/dialogs in the back-end. Other image formats show up as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Log into our Demo Site: https://demo.dotcms.com/dotAdmin
  2. Go to the Site Browser, then go to the /images/gallery/ folder and upload the following GIF file. You'll see that the image file will show up correctly in there:

10-off-50

  1. Create a Content Type called Test CT with two fields:
    3.1 Text Field called Title.
    3.2 Image Field called Image.
  2. Create a new Contentlet of type Test CT. For the Image field, click the BROWSE... button to open up the File Selector widget. Go to the /images/gallery/ folder, and you'll notice that the GIF image is showing up as broken:

file_selector

  1. When you select the file, you'll notice that the image is also broken in the Content Edit portlet:

content-edit

Expected behavior
dotCMS must be able to handle common image file types.

Additional context
As mentioned before, the GIF file shows up correctly when you double-click/edit the image Contentlet itself from the Site Browser. The Image Servlet used to render the preview here is: https://demo.dotcms.com/contentAsset/image/235a4654-9e13-48d8-b972-43bba312def3/fileAsset/filter/Thumbnail/thumbnail_h/250/r/60354484

However, the Image Servlet used in the Content Edit portlet is: https://demo.dotcms.com/dA/235a4654-9e13-48d8-b972-43bba312def3/250w/20q/rand/0.8582981095344357?language_id=1
@jcastro-dotcms jcastro-dotcms added this to the Maintenance Sprint milestone Sep 25, 2020
@john-thomas-dotcms
Copy link
Contributor

So just a couple notes:

  • It appears we changed the URL format that displays the thumbnails in the content editing portlet and the file/image field file selection modal.
    • So a quick fix might just be to change the paths back to the /contentAsset/image format.
  • But I'm wondering if there might be a more general issue with the /dA format not supporting image transformations with GIF files.
    • The new (/dA) paths seem to work fine with images other than GIFs.
    • The /contentAsset/image paths seem to work fine with GIFs.
    • So that suggests the new (/dA) paths might not handle GIF transformations properly.

@wezell
Copy link
Contributor

wezell commented Sep 25, 2020

Also interesting, this does not look broken on master - I tried an image field and the card view and both worked.

Screen Shot 2020-09-25 at 2 48 31 PM

@freddyucv freddyucv self-assigned this Oct 16, 2020
freddyucv pushed a commit that referenced this issue Oct 23, 2020
@freddyDOTCMS
#19338 Using FileInoutStream instead File
5193459
dsilvam added a commit that referenced this issue Oct 27, 2020
@dsilvam
#19338 attempt
cf51622
dsilvam added a commit that referenced this issue Oct 28, 2020
@dsilvam
#19338 dont lowercse
6a2c522
dsilvam added a commit that referenced this issue Oct 28, 2020
@dsilvam
#19338 dont lowercase
e289aed
@dsilvam dsilvam assigned dsilvam and unassigned freddyucv Oct 28, 2020
@victoralfaro-dotcms
Copy link
Contributor

Working as expected.
image

@jcastro-dotcms
Copy link
Contributor Author

NOTE FOR QA: This issue must be tested in a Cloud Instance, as it is NOT reproducible in a local environment.

@dsilvam
Copy link
Contributor

dsilvam commented Oct 28, 2020

It is @jcastro-dotcms but you need to run on Docker.

dsilvam added a commit that referenced this issue Oct 28, 2020
@dsilvam
#19338 integration test
041dc19
dsilvam added a commit that referenced this issue Oct 28, 2020
@dsilvam
#19338 missing test resource
867df5f
dsilvam added a commit that referenced this issue Oct 29, 2020
@dsilvam
#19338 dont lowercase (#19506)
c7c335d 
* #19338 dont lowercase

* #19338 integration test

* #19338 missing test resource
@dsilvam dsilvam added the Merged label Oct 29, 2020
@dsilvam dsilvam removed their assignment Oct 29, 2020
@victoralfaro-dotcms
Copy link
Contributor

Tested on a local docker image.
Browsing for gif image creating new contentlet.
image
Selecting image file
image

@bryanboza
Copy link
Member

Fixed, tested in a docker instance and now it works as expected
image

Tested with this image: dotcms/dotcms:20.10.1-prerelease

dsilvam added a commit that referenced this issue Nov 4, 2020
@dsilvam @jdotcms
@erickgonzalez @hmoreras @freddyDOTCMS @wezell
Release 20.10.1 (#19544)
cf173d7 
* Update dotcmsReleaseVersion and coreWebReleasion version

* update release version

* #18505 JSONTool does not return sub arrays

* #18505 now the JSONTool uses the Jackson to map the string json as a single Maps and Lists

* #18505 now the JSONTool uses the Jackson to map the string json as a single Maps and Lists

* #19364 Unable to edit category permissions as limited user even you have full rights

* #18314 Make Query Tool Use fetch() to fill response

* #19098 SAML update logout page.  (#19450)

* include css in jsp

* label updated

* Updating sql files (#19478)

* Updating sql files to remove contraints

* Updating sql files to remove contraints

* #18690 Allow Push publish just for enterprise license in the receiver (#19492)

* #18690 Allow Push publish just for enterprise license in the receiver

* testing

* Fixing test

* Issue 19500 sql injection containers (#19501)

* #18605 pauses and then unpauses based on a cache invalidation

* #18605 adding ttl to the cache put in the logger

* #18605 less logging

* #19500 sanitize sql

* #19500 fixes potential sql vunerabilities

* #19500 writing tests

* #19500 tests

* we should not need TLS set to true

* #19500 removing unneeded files

* #19338 dont lowercase (#19506)

* #19338 dont lowercase

* #19338 integration test

* #19338 missing test resource

* #19509 use proper db columm in query (#19510)

* #19509 use proper db columm in query

* #19509 use proper property from contentlet

* #19509 fix integration test

* #19509 fix integration test

* #19471 Use proper value when discarding conflicts (#19519)

* #18780 fixes job when new hostname starts with  original hostname (#19522)

* #19509 Fixing bug when use comma in host's name (#19528)

* #19509 Fixing bug when use comma in host's name

* Fixing test

* update core-web version

* merge with master

* Update .gitmodules

* Update gradle.properties

Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>
Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
Co-authored-by: hmoreras <31667212+hmoreras@users.noreply.github.com>
Co-authored-by: Freddy Rodriguez <freddy0309@gmail.com>
Co-authored-by: Will Ezell <will@dotcms.com>
@wezell wezell closed this as completed Nov 4, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotCMS : Content Management Merged QA : Approved QA : Passed Internal Release : 20.10.1 Type : Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@wezell @dsilvam @bryanboza @erickgonzalez @jcastro-dotcms @freddyucv @john-thomas-dotcms @victoralfaro-dotcms