Container error using templates from different sites

[bryanboza]

We have problems when you use a file-based container and templates from different sites, we have a NotFoundInDbException and we are unable to edit the page.

To recreate:

• Login as admin
• Create a new site
• Add a new page on this site (using the default template)
• Open the page and try to edit to add some piece of content

Stacktrace

ST: https://gist.github.com/bryanboza/9eccb75cd8c597cf1542e58a1212dd5e

Expected

We need be able to support that case since is a common use case

Testing info:

Tested on release-5.3.3 // Postgres // FF

Fix: The fix was use always absolute path into the page's layout, the relative path only will be allow in advance template and it should be resolve using the current host.
Also was created a Task Upgrate to change all the relative path in not advance template into absolute path.
Also a Job was created to change all the host's name in the absolute path when the host's name was changed in edit content

[jcastro-dotcms]

As @bryanboza said, this is a very common use case. Please treat this ticket as high priority

[fmontes]

Next release based on this conversation: https://dotcms.slack.com/archives/CE1TBQU00/p1593122028046400

[dsilvam]

PR: #18935

[freddyucv]

Note to QA:

Tested:
Before run TaskUpgrade

• Running the Task05380ChangeContainerPathToAbsolute Task upgrade with the end point

POST  http://localhost:8080/api/v1/upgradetask {
    			"upgradeTaskClass":"com.dotmarketing.startup.runonce.Task05380ChangeContainerPathToAbsolute"
			}

the follow statement was run in the data base before and after the task upgrade

select count(*) from template where drawed_body LIKE '%demo.dotcms.com%’,

the result before the tsk upgrade was 0, after was 82.

• Create a new empty site, create a page and create a new template, add a file container in another site, run the upgrade task and check the template in database should point to the another site
• Create a page in the new site with a template in another site, go to layout and change layout, run the upgrade task and check the container path in data base

After run first the TaskUpgrade and flush cache

• A new page was created, add a File Container from another site into the layout, and check in data base if the path is absolute.

• A new page was created, add a File Container from same site into the layout, and check in data base if the path is absolute.

• Created a new template in the Template manager and add a File Container from the same site into it, check in data base if the path is absolute.

• Created a new template in the Template manager and add a File Container from another site into it, check in data base if the path is absolute.

• Created a new Template in the Template Manager, add a Container (any type), add a slide bar and add the same Container into it, check if the UUID are sequencials, Later edit the template and add the same container one more time the UUID should be 3.

• A new page was created, Add a FileContainer (in the same site) into the Layout, copy the site checking the copy container check, and check that in the site the page is linked with the container in the new site and not with the container in the original site.

• A new page was created, Add a FileContainer (in the same site) into the Layout, copy the site unchecking the copy container check, and check that in the site the page is linked with the container in the original site.

  • Copied demo.dotcms.com, and create a new site named new_site_1, created a new page in new_site_1, and add a FileContainer from the demo.dotcms.com, copy the new_site_1 (created a new site named new_site_2), checking the copy containers check, Cheking that the containers in the new page in linked with the containers in demo.dotcms.com

• Change the host's name, in any host and check that the all the page are working

• Create a new advanced template with a relative path, add this template to a new page, it should work in resolve the relative path in the current host, copy the site checking the copy containers check, the container in the new page should be resolve with the container in the new site.

• Repeat the test before but copy the site unchecking the copy containers check, the container in the new page should be resolve with the container in the default site. (This is correctly resolved at Edite Page level but not at REST Page API containers)

• Created a new page add content into it, and rename the host, the page should has the content after the host's name.

• Copy demo.dotcms.com in the full starter and check the index page in the new site, should use the File containers in the new site

• Copy the demo.dotcms.com site and create demo_2 site, checking the copy containers check, later copy teh demo_2 site and create a new demo_3 site checking the copy containers check again, check that the containers path in the Template Layout has the demo_3

[wezell]

Container resolution strategy

1. If the container exists on the //host referenced host, use it
2. if no //host, try current host
3. If not there, try the default host

[wezell]

Also, we need to show the host next to the container in the layout screen.

[freddyucv]

PR:
core: #19122
core-web: dotCMS/core-web#1419
ee: https://github.com/dotCMS/enterprise-2.x/pull/743

[dsilvam]

Passed Internal QA: Failing case mentioned above is now working.

[bryanboza]

• After the changes, now we are unable to change the template from a page that is using the template from a different site
  SC: https://gist.github.com/bryanboza/1ba321e92b559f1baf6d43d62121847b

• The same thing if you try to modify something in the layout
  

[dsilvam]

Passed Internal QA: Failures reported by @bryanboza on the last comment are working as expected

[bryanboza]

Fixed, tested on release-5.3.9. // Postgres // FF

[ian-b-cooper]

This is seen here https://dotcms.zendesk.com/agent/tickets/105352 as a current customer issue

[swicken-dotcms]

This will not be backported to 5.3.8.X as the changes are too extensive