Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorite pages: Remove the Share with dropdown #24742

Closed
fmontes opened this issue Apr 25, 2023 · 3 comments · Fixed by #24751
Closed

Favorite pages: Remove the Share with dropdown #24742

fmontes opened this issue Apr 25, 2023 · 3 comments · Fixed by #24751
Assignees
@alfredo-dotcms @rjvelazco
Labels
OKR : Core Features Owned by Will Priority : 2 High QA : Approved QA : Passed Internal Release : 23.06 Team : Lunik Type : New Functionality

Comments

@fmontes
Copy link
Member

fmontes commented Apr 25, 2023

Parent Issue

#22343

User Story

As a stakeholder I want to simplify this feature to release ASAP.

We are removing the "Share with" dropdown and user will be able to create favorites only for themselves for now.

Acceptance Criteria

  1. Remove the Share With dropdown
  2. Make sure clean up everything including testing, services, store and state related to this
  3. Add +owner:dotcms.org.2795 to the favorite pages list query (in the portlet)
  4. Add +owner:dotcms.org.2795 to the query to get the "start" in the edit page

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@alfredo-dotcms alfredo-dotcms self-assigned this Apr 25, 2023
alfredo-dotcms added a commit that referenced this issue Apr 25, 2023
@alfredo-dotcms
#24742 DotFavorite remove Share With - commented code
2ad6ae6
alfredo-dotcms added a commit that referenced this issue Apr 25, 2023
@alfredo-dotcms
#24742 DotFavorite remove Share With - code cleanup
6cd85ba
alfredo-dotcms added a commit that referenced this issue Apr 25, 2023
@alfredo-dotcms
#24742 DotFavorite remove Share With - set current role owner
686a76b
@alfredo-dotcms alfredo-dotcms linked a pull request Apr 25, 2023 that will close this issue
Issue 24742 dot favorite portlet remove share with dropdown #24751
Merged
3 tasks
@alfredo-dotcms
Copy link
Contributor

PR: #24751

@fmontes fmontes mentioned this issue Apr 26, 2023
Closed
alfredo-dotcms added a commit that referenced this issue Apr 26, 2023
@alfredo-dotcms
#24742 DotFavorite remove Share With - set current role owner
82c41a0
fmontes pushed a commit that referenced this issue Apr 26, 2023
@alfredo-dotcms
Fix #24742 dot favorite portlet remove share with dropdown (#24751)
e164638 
* #24742 DotFavorite remove Share With - commented code

* #24742 DotFavorite remove Share With - code cleanup

* #24742 DotFavorite remove Share With - set current role owner
@rjvelazco rjvelazco self-assigned this May 2, 2023
@rjvelazco
Copy link
Contributor

Passed Internal QA

The dropdown menu has been removed.

Docker Image: [dotcms/dotcms:master_3b0b1cfc]

Image

@josemejias11
Copy link
Contributor

Approved QA - Tested on master_707fea3d_SNAPSHOT // Docker // macOS 13.0 // FF v112.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfredo-dotcms alfredo-dotcms

@rjvelazco rjvelazco

Labels
OKR : Core Features Owned by Will Priority : 2 High QA : Approved QA : Passed Internal Release : 23.06 Team : Lunik Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 24742 dot favorite portlet remove share with dropdown dotCMS/core
4 participants
@fmontes @alfredo-dotcms @rjvelazco @josemejias11