Issue 24742 dot favorite portlet remove share with dropdown #24751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
reviewed
Apr 26, 2023
| this.dotPageRenderService.get({ url: favoritePageUrl }), | ||
| this.getContentletPermissionsObservable(favoritePage?.identifier) | ||
| ]); | ||
| return forkJoin([this.dotPageRenderService.get({ url: favoritePageUrl })]); |
There was a problem hiding this comment.
Maybe we don't need the forkJoin
zJaaal
approved these changes
Apr 26, 2023
fmontes
requested changes
Apr 26, 2023
| this.dotPageRenderService.get({ url: favoritePageUrl }), | ||
| this.getContentletPermissionsObservable(favoritePage?.identifier) | ||
| ]); | ||
| return forkJoin([this.dotPageRenderService.get({ url: favoritePageUrl })]); |
alfredo-dotcms
force-pushed
the
issue-24742-DotFavoritePortlet-remove-share-with-dropdown
branch
from
686a76b
to
82c41a0
Compare
|
SonarQube Quality Gate
|
fmontes
approved these changes
Apr 26, 2023
zJaaal
approved these changes
Apr 26, 2023
fmontes
deleted the
issue-24742-DotFavoritePortlet-remove-share-with-dropdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots