Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webp support for m1 macs #25172

Closed
spbolton opened this issue Jun 7, 2023 · 0 comments · Fixed by #25173
Closed

Fix webp support for m1 macs #25172

spbolton opened this issue Jun 7, 2023 · 0 comments · Fixed by #25173
Labels
dotCMS : Technical Debt Dealing with long standing tech debt OKR : Code Maintenance Owned by Erick Team : Architecture

Comments

@spbolton
Copy link
Contributor

spbolton commented Jun 7, 2023

Updating to use io.github.darkxanter:webp-imageio:0.3.2 https://github.com/darkxanter/webp-imageio for webp support, this is a fork of https://github.com/sejda-pdf/webp-imageio that is compiled with m1 binaries.

The package structure has changed so we need to change the hardcoded r instanceof net.sf.javavp8decoder.imageio.WebPImageReader to make use of the provided vendor name e.g. r.getOriginatingProvider().getVendorName().equals("Luciad"). This change is backwards compatible as our existing uses the same vendor name.

This allows the BinaryServletExporterTest to run directly on M1 macs.

requestGifFile has an byte encoded version of an output image as a test, there is minor change in the new version to the binary of the generated image so this is needed to be updated.

@spbolton spbolton added dotCMS : Technical Debt Dealing with long standing tech debt Team : Architecture OKR : Code Maintenance Owned by Erick labels Jun 7, 2023
@spbolton spbolton linked a pull request Jun 7, 2023 that will close this issue
spbolton added a commit that referenced this issue Jun 7, 2023
spbolton added a commit that referenced this issue Jun 7, 2023
spbolton added a commit that referenced this issue Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotCMS : Technical Debt Dealing with long standing tech debt OKR : Code Maintenance Owned by Erick Team : Architecture
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant