Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebP on m1 macs #25172 #25173

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Conversation

spbolton
Copy link
Contributor

@spbolton spbolton commented Jun 7, 2023

Issue #25172

Descriiption

Adds support for mac m1 processor for webp processing allowing BinaryExporterServletTest to succeed locally on an m1 mac

🤖 Generated by Copilot at 526f096

Summary

🧹🐛📝

This pull request improves the image filter functionality of dotCMS by updating the dependencies, fixing a test case, cleaning up the code, and adding documentation. It affects the dependencies.gradle file, the BinaryExporterServletTest class, the ImageFilterAPI interface, the ImageFilterApiImpl class, and the ImageFilterExporter class.

This pull request is quite a treat
It makes the code more clean and neat
It updates dependencies.gradle
And fixes a test that failed
And adds comments to ImageFilterAPI

Walkthrough

  • Remove unused variables and imports from dependencies.gradle and BinaryExporterServletTest.java (link, link)
  • Update dependency for webp-imageio library to version 0.3.2 in dependencies.gradle (link)
  • Update expected content of WebP image in BinaryExporterServletTest.java to fix failing test case (link)
  • Remove unused constant and add Javadoc comments to ImageFilterAPI.java interface (link, link, link, link, link, link, link)
  • Fix typo, update generic types, refactor logic, and add Javadoc comments to ImageFilterApiImpl.java class (link, link, link, link, link, link, link)
  • Fix typo, add HTML tags, update generic types, and replace string literal in ImageFilterExporter.java class (link, link, link, link)

@spbolton spbolton linked an issue Jun 7, 2023 that may be closed by this pull request
@spbolton spbolton merged commit a103701 into master Jun 9, 2023
@spbolton spbolton deleted the 25172-fix-webp-support-for-m1-macs branch June 9, 2023 04:37
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 3.4% 3.4% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix webp support for m1 macs
3 participants