Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Only show 3 significant digits in Experiments results table #26355

Closed
john-thomas-dotcms opened this issue Oct 4, 2023 · 2 comments · Fixed by #26488
Closed

[UI] Only show 3 significant digits in Experiments results table #26355

john-thomas-dotcms opened this issue Oct 4, 2023 · 2 comments · Fixed by #26488
Labels
dotCMS : Experiments Analytics Umbrella: Experiments Feature Merged OKR : Core Features Owned by Will QA : Approved QA : Needs Internal Release : 23.12.21 SEO Improvements Team : Falcon Type : Enhancement

Comments

@john-thomas-dotcms
Copy link
Contributor

john-thomas-dotcms commented Oct 4, 2023 •
edited
Loading

Problem

In the Experiments results table, we show the numbers for Conversion Rate and Conversion Rate Range with 2 decimal places. But we show the Probability to be Best with only 1 decimal place.

This is inconsistent, and in most cases, showing 2 decimal places is unnecessary.

Solution

Change all 3 values (Conversion Rate, Conversion Rate Range, and Probability to be Best) to show 3 digits of precision. This means:

  • Value >= 10: Show 1 decimal place
  • Value < 10: Show 2 decimal places
@john-thomas-dotcms john-thomas-dotcms converted this from a draft issue Oct 4, 2023
@john-thomas-dotcms john-thomas-dotcms changed the title Only show 1 decimal place in Experiments results numbers Only show 3 significant digits in Experiments results table Oct 4, 2023
@john-thomas-dotcms john-thomas-dotcms changed the title Only show 3 significant digits in Experiments results table [UI] Only show 3 significant digits in Experiments results table Oct 4, 2023
@hmoreras hmoreras self-assigned this Oct 18, 2023
@hmoreras hmoreras moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Oct 18, 2023
@hmoreras hmoreras moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Oct 18, 2023
@hmoreras hmoreras linked a pull request Oct 22, 2023 that will close this issue
dotCMS/core#26355 [UI] Only show 3 significant digits in Experiments results table #26488
Merged
@hmoreras hmoreras moved this from In Progress to In Review in dotCMS - Product Planning Oct 23, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Oct 23, 2023
@dsilvam dsilvam reopened this Oct 23, 2023
@github-project-automation github-project-automation bot moved this from Done to Current Sprint Backlog in dotCMS - Product Planning Oct 23, 2023
@dsilvam dsilvam moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Oct 23, 2023
@dsilvam
Copy link
Contributor

dsilvam commented Oct 23, 2023

Passed Internal QA: Showing decimals according to the rules included in the description above.

@dsilvam dsilvam moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Oct 23, 2023
@bryanboza
Copy link
Member

Fixed, tested on master and now this value is showing just one decimal.

Image

@bryanboza bryanboza moved this from QA - Backlog to Done in dotCMS - Product Planning Nov 9, 2023
@erickgonzalez erickgonzalez added the LTS : Next Ticket that will be added to LTS label Nov 14, 2023
@erickgonzalez erickgonzalez added Experiments LTS Issues Related to Experiments that we need in LTS and removed LTS : Next Ticket that will be added to LTS labels Dec 13, 2023
@bryanboza bryanboza added Release : 23.12.21 SEO Improvements and removed Release 23.12.21 labels Dec 22, 2023
@erickgonzalez erickgonzalez removed the Experiments LTS Issues Related to Experiments that we need in LTS label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotCMS : Experiments Analytics Umbrella: Experiments Feature Merged OKR : Core Features Owned by Will QA : Approved QA : Needs Internal Release : 23.12.21 SEO Improvements Team : Falcon Type : Enhancement
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dotCMS/core#26355 [UI] Only show 3 significant digits in Experiments results table dotCMS/core
6 participants
@dsilvam @bryanboza @erickgonzalez @john-thomas-dotcms @hmoreras @victoralfaro-dotcms