Enhance MonitorInfo class #168
Conversation
src/WinUIEx/MonitorInfo.cs
Outdated
| /// <summary> | ||
| /// Gets if the monitor is the the primary display monitor. | ||
| /// </summary> | ||
| public bool IsPrimary { get; } |
There was a problem hiding this comment.
I wonder if it would be better to move line 50 to here:
public bool IsPrimary => _monitor == PInvoke.MonitorFromWindow(new(IntPtr.Zero), MONITOR_FROM_FLAGS.MONITOR_DEFAULTTOPRIMARY);
That ensures it is up to date, in case of changes, and doesn't require the extra interop call if you're never actually checking this
src/WinUIEx/MonitorInfo.cs
Outdated
| /// <inheritdoc /> | ||
| public override string ToString() => $"{Name} {RectMonitor.Width}x{RectMonitor.Height}"; | ||
| public override string ToString() => $"{Name} {(IsPrimary ? " Primary" : "")} {RectMonitor.Width}x{RectMonitor.Height}"; |
There was a problem hiding this comment.
I don't think we should be changing ToString here, What was the reasoning for this?
There was a problem hiding this comment.
Ok, we can remove this. I really don't know what should be contained in ToString function.
|
I have edited my codes with your advice. |
Jack251970
changed the title
|
Add support to get the display monitor closest to a given window. |
|
Add support for relative coordinates. |
src/WinUIEx/MonitorInfo.cs
Outdated
| /// <remarks> | ||
| /// <note>For display monitor coordinates, the origin is the upper-left corner of the display monitor.</note> | ||
| /// </remarks> | ||
| public Point PointMonitor { get; } |
There was a problem hiding this comment.
I don't quite get the point of this - it's already available in RectMonitor
| public unsafe static MonitorInfo GetWindowDisplayMonitor(IntPtr hwnd) | ||
| { | ||
| var windowMonitor = PInvoke.MonitorFromWindow(new(hwnd), MONITOR_FROM_FLAGS.MONITOR_DEFAULTTONEAREST); | ||
| MonitorInfo monitorInfo = null!; |
There was a problem hiding this comment.
Why the null-forgiveness? It seems to me this method could end up returning null if the condition is false.
| /// </summary> | ||
| /// <param name="hwnd">Window handle</param> | ||
| /// <returns>The display monitor that is nearest to a given window.</returns> | ||
| public unsafe static MonitorInfo GetWindowDisplayMonitor(IntPtr hwnd) |
There was a problem hiding this comment.
Probably better to just name this MonitorFromWindow to match the interop method. What's the difference between a "monitor" and a "display monitor" ?
When I was working on a project using WinUIEx, I found that the MonitorInfo class could not provide parameters related to the primary monitor.
So, I went online to search and complete this commit.
Hopefully I'll get this update in the Nuget package soon!