Extract VDF's into separate JSON files, with and without duplicate keys allowed #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduces a new output which essentially allows duplicate keys in the output. users should choose which file they wish to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An internal project got caught out by the previous change (#7) where we expected a certain structure of JSON to be output. This workaround means that we revert to the previous behaviour of disallowing duplicate keys in the json output. Instead, we now extract VDF into a separate file;
_with_dupes.jsonalongside the original.Users should choose whether they need a static structure (without the possibility of duplicate keys) or whether they need to use a flexible structure (so you can read different values from duplicated keys).
For example, for
items_game.json, the original no longer allows duplicate keys, whereasitems_game_with_dupes.jsonallows duplicate keys.