Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix validations on fragments/operations naming conflicts #8606

Merged
merged 6 commits into from
Nov 14, 2022

Conversation

charlypoly
Copy link
Contributor

@charlypoly charlypoly commented Nov 14, 2022

Fix #8570

@charlypoly charlypoly self-assigned this Nov 14, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2022

🦋 Changeset detected

Latest commit: d682596

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-codegen/core Patch
@graphql-codegen/cli Patch
@graphql-cli/codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-cli/codegen 2.4.15-alpha-20221114111325-6217e61e1 npm ↗︎ unpkg ↗︎
@graphql-codegen/cli 2.13.12-alpha-20221114111325-6217e61e1 npm ↗︎ unpkg ↗︎
@graphql-codegen/core 2.6.6-alpha-20221114111325-6217e61e1 npm ↗︎ unpkg ↗︎

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test here for this so when we upgrade tools next time we hopefully know it doesn't break?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://1af3ee15.graphql-code-generator.pages.dev

@charlypoly
Copy link
Contributor Author

can we add a test here for this so when we upgrade tools next time we hopefully know it doesn't break?

Agree, we added a integration test in tools 👀

@charlypoly charlypoly merged commit 45eb2b1 into master Nov 14, 2022
@charlypoly charlypoly deleted the fix/validation-fragments branch November 14, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@graphql-codegen/cli >= 2.13.10 causes "Unknown fragment" error
2 participants