Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop importing fragments that are now unused #9194

Merged
merged 5 commits into from
Mar 29, 2023

Conversation

dstaley
Copy link
Contributor

@dstaley dstaley commented Mar 16, 2023

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

This PR builds on #9136, fixing some TypeScript errors so that we can get tests running to verify if the change introduces any test failures.

Related dotansimha/graphql-code-generator-community#289
#9136

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

This PR is mainly to verify that the changes in #9136 work; running tests locally seemed to produce failures in unrelated areas, so I wanted to double-check and see if those failures also occur in CI.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

🦋 Changeset detected

Latest commit: b128a39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@graphql-codegen/visitor-plugin-common Patch
@graphql-codegen/typescript-document-nodes Patch
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/typescript-operations Patch
@graphql-codegen/typescript-resolvers Patch
@graphql-codegen/typed-document-node Patch
@graphql-codegen/typescript Patch
@graphql-codegen/graphql-modules-preset Patch
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan
Copy link
Collaborator

ardatan commented Mar 16, 2023

Could you add some tests to show the issue and prevent future regressions?

@dstaley
Copy link
Contributor Author

dstaley commented Mar 17, 2023

@ardatan Added a test! I'm not confident the configuration is technically correct, but I did confirm that the test correctly demonstrates the issue using the previous version of the code, and that the test now passes with the code in this PR.

@n1ru4l n1ru4l self-requested a review March 22, 2023 13:07
@saihaj saihaj requested a review from ardatan March 23, 2023 16:24
@saihaj saihaj merged commit acb647e into dotansimha:master Mar 29, 2023
@dstaley dstaley deleted the pr-9136-imports branch November 1, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants