Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicating graphiQL default status when in production #3242

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

mwelwankuta
Copy link
Contributor

This PR includes a setence correction/update that includes that when in development graphiql is accessible on the /graphql endpoint and not when in production, unless the graphiql option is updated.

This PR referenes #3158

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: 856f6bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ardatan ardatan merged commit efaa2b1 into dotansimha:main Apr 24, 2024
5 checks passed
Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 401438      ✗ 0     
     data_received................................: 1.6 GB  14 MB/s
     data_sent....................................: 81 MB   675 kB/s
     http_req_blocked.............................: avg=1.39µs   min=962ns    med=1.26µs   max=283.7µs  p(90)=1.82µs   p(95)=2.03µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=139.29µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=388.5µs  min=219.52µs med=340.7µs  max=31.13ms  p(90)=544.1µs  p(95)=567.92µs
       { expected_response:true }.................: avg=388.5µs  min=219.52µs med=340.7µs  max=31.13ms  p(90)=544.1µs  p(95)=567.92µs
     ✓ { mode:graphql-jit }.......................: avg=294.37µs min=219.52µs med=269.33µs max=14.43ms  p(90)=304.32µs p(95)=319.94µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=570.84µs min=482.35µs med=542.36µs max=9.81ms   p(90)=592.09µs p(95)=630.31µs
     ✓ { mode:graphql-response-cache }............: avg=365.09µs min=293.55µs med=343.05µs max=7.48ms   p(90)=379.74µs p(95)=393.38µs
     ✓ { mode:graphql }...........................: avg=386.06µs min=298.2µs  med=348.51µs max=31.13ms  p(90)=398.99µs p(95)=444.45µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 200719
     http_req_receiving...........................: avg=33.15µs  min=16.44µs  med=32.93µs  max=4.06ms   p(90)=38.38µs  p(95)=40.56µs 
     http_req_sending.............................: avg=7.76µs   min=5.75µs   med=6.91µs   max=1.08ms   p(90)=10.37µs  p(95)=11.07µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=347.58µs min=190.79µs med=300.95µs max=30.96ms  p(90)=502.65µs p(95)=523.95µs
     http_reqs....................................: 200719  1672.634533/s
     iteration_duration...........................: avg=593.19µs min=396.79µs med=540.33µs max=32.16ms  p(90)=752.44µs p(95)=781.69µs
     iterations...................................: 200719  1672.634533/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants