Added option to display login URL during login #175
Conversation
|
Thank you for this @Dannomac. I will review it soon. Might move some things around slightly. Symmetry is very important in the tool, and I don't like that this adds an additional command. Possibly we should just list the url prior to asking to continue or not? Then the dev can abort but still copy and paste the url? |
|
Yeah totally agree. Seems like a simpler idea. Let me know if you want me to do anything to help! |
|
I don't want to give you more work that might get thrown out, but could you re-adjust it to that if you find the time? Go ahead and do so for all commands that list out a url. Then we'll give it a test run in our terminals to see the 'feel' of it. My only worry then is it might feel too verbose of output on the screen, but I think it will be ok. |
|
Absolutely. It's quite late where I am but I'll have a look at it tomorrow. |
This reverts commit 21c2974.
|
@motdotla Added new features. Let me know if you'd like me to make any more changes. |
|
looks good! merging |
|
Released as 1.17.0. I made some modifications. |
This PR adds the ability to display the login URL to the CLI rather than opening in the default browser. Useful if you are using a browser that is not set as your default.