Rc1-Rc2 #1253

rachelappel · 2016-05-19T17:43:04Z

danroth27 · 2016-05-19T18:18:57Z

@JunTaoLuo @DamianEdwards @Rick-Anderson Please review

JunTaoLuo · 2016-05-19T18:40:12Z

aspnet/migration/rc1-to-rc2.rst

@@ -17,7 +17,7 @@ For information regarding a complete list of breaking changes in RC2 for ASP.NET
 Creating your web application host
 ----------------------------------

-Since ASP.NET Core apps are just console apps, you must define an entry point for your application in ``Program.Main`` that sets up a web host, then tells it to start listening. Below is an example of the startup code for the built-in `Web Application` template in Visual Studio.
+Since ASP.NET Core apps are just console apps, you must define an entry point for your application in ``Program.Main()`` that sets up a web host, then tells it to start listening. Below is an example of the startup code for the built-in `Web Application` template in Visual Studio.


then tell it to start listening

Since "the entry point" is the subject... "tells" is the correct grammar. To verify, use the standard grammar technique of removing the superfluous verbiage, "for your application in Program.Main() that sets up a web host" and read the sentence, which is then "the entry point tells it to start listening".
(See the Strunk & White manual for clarification). I can reword for two sentences though if it sounds more appealing.

I read the sentence with you being the subject. As in you must define ... then you tell it to start listening. It's awkward phrasing and splitting it into two sentence is much better.

Rick-Anderson · 2016-05-20T21:12:27Z

See new DISQUS comments. Also, can you put the article title in the PR next time?

JunTaoLuo · 2016-05-25T19:37:38Z

aspnet/migration/rc1-to-rc2.rst

+ASPNET_APP, ASPNET_APPLICATIONNAME, Hosting:App      ASPNETCORE_APPLICATIONNAME
+ASPNET_STARTUPASSEMBLY                               ASPNETCORE_STARTUPASSEMBLY
+ASPNET_DETAILEDERRORS, Hosting:DetailedErrors        ASPNETCORE_DETAILEDERRORS
+ASPNET_ENVIRONMENT, ASPNET_ENV, Hosting:Environment  ASPNETCORE_ENVIRONMENT


We still support ASPNET_ENV, Hosting:Environment in RC2 but the user will see a message indicating these values are deprecated.

@JunTaoLuo No need to mention that since the legacy env vars will go away.

JunTaoLuo · 2016-05-25T19:40:06Z

@danroth27 these changes looks accurate to me and we should update the document soon. If there are further changes we want to make (like re-ordering of sections), we should do that now or in a follow up PR.

rachelappel · 2016-05-26T08:22:55Z

@danroth27 need a tree rat

danroth27 · 2016-05-26T17:04:38Z

aspnet/migration/rc1-to-rc2.rst

@@ -14,10 +14,53 @@ ASP.NET 5 RC1 apps were based on the .NET Execution Environment (DNX) and made u

 For information regarding a complete list of breaking changes in RC2 for ASP.NET Core, see the `ASP.NET Core Announcements page <https://github.com/aspnet/announcements/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.0.0-rc2>`_

+Changes in MVC


Starting with MVC feels weird to me since it is at the top of the stack. Can we move this below "Namespace and package ID changes"?

danroth27 · 2016-05-26T17:57:47Z

Starting at line 159:

The hosting configuration keys are now consistent with the command line, environment variables, and hosting.json values. The Microsoft.AspNet.Hosting.json configuration file was renamed to hosting.json.

hosting.json is no longer read by default, users need to explicitly add their own configuration sources and pass a configuration to WebHostBuilder. The default server URL and port are localhost:5000.

This seems to be going through changes that were made between RC1 and RC2. I think both paragraphs can be removed. Specifying a configuration instance for the web host is covered at the end of the "Creating your web application host" section.

danroth27 · 2016-05-26T18:01:44Z

aspnet/migration/rc1-to-rc2.rst

@@ -136,7 +193,7 @@ HttpPlatformModule

 ``Microsoft.AspNetCore.IISPlatformHandler`` is now ``Microsoft.AspNetCore.Server.IISIntegration``.

-HttpPlatformModule was replaced by ASP.NET Core Module. The web.config created by the Publish IIS tool now configures IIS to use ASP.NET Core Module instead of HttpPlatformHandler to reverse-proxy requests to Kestrel.
+HttpPlatformModule was replaced by ASP.NET Core Module. The ``web.config`` created by the Publish IIS tool now configures IIS to use ASP.NET Core Module instead of HttpPlatformHandler to reverse-proxy requests to Kestrel.


HttpPlatformModule -> HTTP Platform Handler. Fix throughout the doc.

I would also remove the subsection headings from the "Working with IIS" section and just cover the new ASP.NET Core Module. Link to "https://docs.asp.net/en/latest/publishing/iis.html" for details about publishing to IIS in RC2 instead of covering the details of the publish-iis tool here.

Ignore the above comment.

danroth27 · 2016-05-27T03:02:27Z

Here are the top level sections I think we should have:

Overview
Specify the .NET Core SDK version
Namespace and package ID changes
Creating your web application host
Hosting configuration
Hosting service changes
Working with IIS
MVC
Configuration
Logging
Identity
Updating Launch Settings in Visual Studio

Other changes:

Rename "Global.json" to "Specify the .NET Core SDK version" and move to the top just below the Overview.
Rename "IHostingEnvironment" section to "Hosting configuration"
Rename "Runtime Services Changes" to "Hosting services"
Changes in MVC -> MVC
Move the content of the Entity Framework section to the end of the Overview section and remove the Entity Framework section heading.
Identity API updates -> Identity
Remove the "WebHostBuilder API updates" section heading and merge it's contents with the "Create your web application host" section.

Rework the "Hosting configuration" section as follows:

Adding the following initial sentence: "You enable configuration for your web application host by calling the UseConfiguration method on WebHostBuilder and passing a configuration instance. The following configuration values can be specified:"
List the configuration keys: application, startupAssembly, detailedErrors, server, webroot, captureStartupErrors, server.urls, contentRoot.
Remove the sentence about env vars being prefixed by ASPNETCORE_ and the env var table.
Explain that to configure hosting using env vars you need to add env vars as a configuration source and optionally specify a prefix.
Specify that the new env var for specifying the environment is ASPNETCORE_ENVIRONMENT.

In the "Creating your web application host" section add the following sentence below the code snippet: "The application base path is now called the content root."

danroth27 · 2016-05-27T03:03:02Z

⌚

Rick-Anderson · 2016-05-27T18:00:20Z

cust writes
There is a change in how the routes are mapped to the application. Can I get some example of how to use new IRouteBuilder.MapRoute method.

danroth27 · 2016-05-27T23:51:42Z

aspnet/migration/rc1-to-rc2.rst


-IHostingEnvironment changes 
---------------------------
+-application


This isn't rendering as a list correctly. You have to have a space after the -.

danroth27 · 2016-05-28T01:05:47Z

⌚

danroth27 · 2016-05-28T16:16:46Z

aspnet/migration/rc1-to-rc2.rst


-WebHostBuilder API updates
--------------------------
+"The default server URL and port are ``localhost:5000``. You can find more information about Garbage Collection configuration at: https://github.com/aspnet/Announcements/issues/175


Remove leading quote

danroth27 · 2016-05-28T16:26:55Z

A couple more minor things, but once those are fixed

dnfclas added the cla-already-signed label May 19, 2016

JunTaoLuo reviewed May 19, 2016
View reviewed changes

JunTaoLuo reviewed May 25, 2016
View reviewed changes

danroth27 reviewed May 26, 2016
View reviewed changes

danroth27 reviewed May 27, 2016
View reviewed changes

danroth27 reviewed May 28, 2016
View reviewed changes

1127 fixes

fd55156

rachelappel force-pushed the rachelap/rc1rc2 branch from d1bfb2a to fd55156 Compare May 31, 2016 16:01

rachelappel merged commit fd55156 into master May 31, 2016

rachelappel deleted the rachelap/rc1rc2 branch June 27, 2016 16:34

This was referenced Nov 18, 2020

[Snyk] Fix for 1 vulnerabilities snyk123/AspNetCore.Docs#7

Open

[Snyk] Fix for 1 vulnerabilities snyk123/AspNetCore.Docs#8

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rc1-Rc2 #1253

Rc1-Rc2 #1253

rachelappel commented May 19, 2016 •

edited by JunTaoLuo

Loading

danroth27 commented May 19, 2016

JunTaoLuo May 19, 2016

rachelappel May 19, 2016 •

edited

Loading

JunTaoLuo May 19, 2016

Rick-Anderson commented May 20, 2016

JunTaoLuo May 25, 2016

danroth27 May 26, 2016

JunTaoLuo commented May 25, 2016

rachelappel commented May 26, 2016

danroth27 May 26, 2016

rachelappel May 26, 2016

danroth27 commented May 26, 2016 •

edited

Loading

danroth27 May 26, 2016 •

edited

Loading

danroth27 May 28, 2016

danroth27 commented May 27, 2016 •

edited

Loading

danroth27 commented May 27, 2016

Rick-Anderson commented May 27, 2016

danroth27 May 27, 2016

rachelappel May 28, 2016

danroth27 commented May 28, 2016

danroth27 May 28, 2016

danroth27 commented May 28, 2016

		@@ -14,10 +14,53 @@ ASP.NET 5 RC1 apps were based on the .NET Execution Environment (DNX) and made u

		For information regarding a complete list of breaking changes in RC2 for ASP.NET Core, see the `ASP.NET Core Announcements page <https://github.com/aspnet/announcements/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.0.0-rc2>`_

		Changes in MVC

Rc1-Rc2 #1253

Rc1-Rc2 #1253

Conversation

rachelappel commented May 19, 2016 • edited by JunTaoLuo Loading

danroth27 commented May 19, 2016

Choose a reason for hiding this comment

rachelappel May 19, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rick-Anderson commented May 20, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JunTaoLuo commented May 25, 2016

rachelappel commented May 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danroth27 commented May 26, 2016 • edited Loading

danroth27 May 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danroth27 commented May 27, 2016 • edited Loading

danroth27 commented May 27, 2016

Rick-Anderson commented May 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danroth27 commented May 28, 2016

Choose a reason for hiding this comment

danroth27 commented May 28, 2016

rachelappel commented May 19, 2016 •

edited by JunTaoLuo

Loading

rachelappel May 19, 2016 •

edited

Loading

danroth27 commented May 26, 2016 •

edited

Loading

danroth27 May 26, 2016 •

edited

Loading

danroth27 commented May 27, 2016 •

edited

Loading