-
-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Set the $RUNTIMESRCDIR$ for interpreter #1759
[wasm] Set the $RUNTIMESRCDIR$ for interpreter #1759
Conversation
Fixes: The "WasmAppBuilder" task failed unexpectedly. System.ArgumentException: File MainJS='$RUNTIMESRCDIR$\src\mono\wasm\runtime-test.js' doesn't exist. at WasmAppBuilder.Execute() in WasmAppBuilder.dll:token 0x6000042+0x27 at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() in Microsoft.Build.dll:token 0x6001602+0x3e at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) in Microsoft.Build.dll:token 0x6001481+0x2b5
I think we also need to (or atleast should) change some of the commandline argument validation here:
|
@@ -112,7 +112,7 @@ private static bool Validate(CommandLineOptions options, ILogger logger) | |||
logger.WriteLineError($"The provided runtime \"{runtime}\" is invalid. Available options are: {string.Join(", ", Enum.GetNames(typeof(RuntimeMoniker)).Select(name => name.ToLower()))}."); | |||
return false; | |||
} | |||
else if (runtimeMoniker == RuntimeMoniker.Wasm && !(options.AOTCompilerMode == MonoAotCompilerMode.wasm) && (options.WasmMainJs == null || options.WasmMainJs.IsNotNullButDoesNotExist())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the other part of the PR uses RuntimeSrcDir
I would expect it to be validaten in this PR?
BenchmarkDotNet/src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs
Lines 124 to 128 in 5196e6f
else if (runtimeMoniker == RuntimeMoniker.Wasm && options.AOTCompilerMode == MonoAotCompilerMode.wasm && (options.RuntimeSrcDir == null || options.RuntimeSrcDir.IsNotNullButDoesNotExist())) | |
{ | |
logger.WriteLineError($"The provided {nameof(options.RuntimeSrcDir)} \"{options.RuntimeSrcDir}\" does NOT exist. It MUST be provided."); | |
return false; | |
} |
@adamsitnik Radek is on vacation and I could not push to his branch, so I created another PR to keep iterating on this: #1763. I think we can close this PR (1759). |
Fixes: