Custom session items when injecting application message #1629
Conversation
| _sessionItems, | ||
| cancellationToken); | ||
|
|
||
| public Task InjectApplicationMessage(InjectedMqttApplicationMessage injectedApplicationMessage, ConcurrentDictionary<object, object> sessionItems, CancellationToken cancellationToken = default) |
There was a problem hiding this comment.
I don't like the idea to pass in session items for every injected message. The server should behave like a single client.
We may need to expose the session items as a public property for MqttServer. It is currently missing the feature to setup session items externally. This is usually done for clients when they connect but the server has no connection at all so we must prepare the session items somewhere else.
There was a problem hiding this comment.
As a part of #1635 I added the ability to get session items using the IMqttServerExtensibility interface. Maybe this is a way of exposing it without opening up a SessionItems dictionary to all? This also allows users to supply whatever session items they want by calling directly to the MqttClientSessionsManager.
|
Closing this PR because a similar change is part of another PR. |
Optional parameter for session items to be used when publishing a message from the server
See #1627