This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that causes the painted area not to match the window when resizing. If the
OnRenderSizeChanged()
override does not call its base implementation theSizeChanged
event isn't raised and the dirty rectangle may be incorrectly sized whenOnPaintSurface()
is called. Note mono / SKElement.cs#L88-L93WDSkiaGraphicsView
inheritsSKElement
which inheritsFrameworkElement
According to
FrameworkElement.OnRenderSizeChanged()
documentation:I realize this project is experimental/preview, so clarification on whether contributions are welcome at this time and if PRs must be accompanied by linked issues would be great! (#88)
Demonstrating the Issue
Before the Fix
Notice the white border around the filled area when resizing quickly
After the Fix
Filled area exactly matches the window size