Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CentOS #219

Closed
AArnott opened this issue Aug 25, 2018 · 4 comments
Closed

Add support for CentOS #219

AArnott opened this issue Aug 25, 2018 · 4 comments
Labels
enhancement

Comments

@AArnott
Copy link
Collaborator

AArnott commented Aug 25, 2018

As @bording points out in #218 (comment), we should update to libgit2sharp 0.26.0, including taking care to load the right native libgit2 library based on RID at runtime so that NB.GV works on more Linux platforms including CentOS.
@bording
Copy link

bording commented Aug 25, 2018

If the plan to remove the OpenSSL and curl dependencies from the native libraries works the way I'm thinking it will, then the work to handle this will be simplified.

My current thinking is that instead of the handful of different RIDs we have in the current 0.26.0 preview, we'd just need two different linux libraries, one for musl libc distros (alpine) and one for everything else.

@bording bording mentioned this issue Nov 3, 2018
Closed
@shawnallen85
Copy link

Any update on this?

@AArnott
Copy link
Collaborator Author

AArnott commented Dec 9, 2018

@bording do you have an issue tracking CentOS support on the libgit2sharp side?
Now that with #244 we support the RID loading for various *nix platforms, I think we can support CentOS as soon as libgit2sharp does.

@bording
Copy link

bording commented Dec 9, 2018

@AArnott With #244, you do already support CentOS. It will use the rhel-x64 RID.

@AArnott AArnott closed this as completed Dec 9, 2018
@AArnott AArnott mentioned this issue Nov 15, 2023
Merged
AArnott pushed a commit that referenced this issue Nov 15, 2023
@dependabot
Bump xunit from 2.5.0 to 2.5.1 (#219)
39bdb37 
Bumps [xunit](https://github.com/xunit/xunit) from 2.5.0 to 2.5.1.
- [Commits](xunit/xunit@2.5.0...2.5.1)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AArnott @bording @shawnallen85