Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert Language special-casing to handle *supported* programming languages. #1021

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Invert Language special-casing to handle *supported* programming languages. #1021

merged 1 commit into from
Jan 16, 2024

Conversation

alexrp
Copy link
Contributor

@alexrp alexrp commented Jan 15, 2024

Closes #1020.

@alexrp
Copy link
Contributor Author

alexrp commented Jan 15, 2024

@AArnott OK to just delete the failing AssemblyInfo_NotProducedWithoutCodeDomProvider test?

@AArnott
Copy link
Collaborator

AArnott commented Jan 15, 2024

This looks great. And yes, go ahead and delete that test.

@AArnott AArnott added this to the v3.7 milestone Jan 15, 2024
@alexrp
Copy link
Contributor Author

alexrp commented Jan 15, 2024

This should be ready for review.

@AArnott AArnott merged commit 549f6f4 into dotnet:main Jan 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.

Consider inverting Language property special-casing
2 participants
@alexrp @AArnott