Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack additional copies of osx and linux libraries under MSBuildFull #227

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Pack additional copies of osx and linux libraries under MSBuildFull #227

merged 1 commit into from
Sep 25, 2018

Conversation

frankbuckley
Copy link

Update nuspec to add back copies of native libraries for OSX and Linux to work around DllNotFoundException when running msbuild under Mono (#222).

Manually verified these now work:

  • Mono msbuild on Mac OS X 10.13.6 (MS Build 15.7.224 on Mono 5.12.0)
  • Mono msbuild on Ubuntu 18.04.1 (MS Build 15.6.0.0 on Mono 5.14.0

Manually verified these continue to work:

  • dotnet build on Mac OS X 10.13.6 (.NET Core SDK 2.1.402)
  • dotnet build on Ubuntu 18.04.1 (.NET Core SDK 2.1.402)
  • dotnet build on Windows 10.0.17134 (.NET Core SDK 2.1.402)
  • .NET Framework msbuild on Windows 10.0.17134 (MS Build 15.8.169)

All tests in NerdBank.GitVersioning.Tests pass (dotnet test on Windows) except one: BuildIntegrationTests.NativeVersionInfo_CreateNativeResourceDll fails with:

InvalidProjectFileException : The imported project "C:\Microsoft.Cpp.Default.props" was not found.

@AArnott AArnott merged commit fd02a0e into dotnet:master Sep 25, 2018
AArnott pushed a commit that referenced this pull request Nov 15, 2023
Bumps [powershell](https://github.com/PowerShell/PowerShell) from 7.3.8 to 7.3.9.
- [Release notes](https://github.com/PowerShell/PowerShell/releases)
- [Commits](PowerShell/PowerShell@v7.3.8...v7.3.9)

---
updated-dependencies:
- dependency-name: powershell
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants