Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions: Use Environment File #516

Merged
merged 2 commits into from Oct 6, 2020

Conversation

talenfisher
Copy link
Contributor

@talenfisher talenfisher commented Oct 5, 2020

Recently, Github Actions deprecated the set-env command in favor of using environment files. Since then, I've been getting a lot of warnings about set-env that stem from its use here.

This PR updates GithubActions.SetCloudBuildVariable to write to the environment file, rather than use the set-env command.

@talenfisher talenfisher marked this pull request as ready for review Oct 6, 2020
Copy link
Collaborator

@AArnott AArnott left a comment

Thanks for contributing! This looks like a good fix. One quick suggestion. What do you think?

@AArnott AArnott added this to the v3.3 milestone Oct 6, 2020
AArnott
AArnott approved these changes Oct 6, 2020
Copy link
Collaborator

@AArnott AArnott left a comment

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants