Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for a keyboard, mouse, and human input API #16

Merged
merged 12 commits into from
Jul 5, 2019
Merged

Proposal for a keyboard, mouse, and human input API #16

merged 12 commits into from
Jul 5, 2019

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Jul 5, 2019

Summary of the PR

This proposal covers the following areas:

  • Silk.NET.Input
  • Silk.NET.Input.Common
  • Silk.NET.Input.Desktop
  • Silk.NET.Input.Mobile

Related issues, Discord discussions, or proposals

None.

Further Comments

None.

@Perksey Perksey added this to the 1.0 milestone Jul 5, 2019
@Perksey Perksey requested a review from a team July 5, 2019 12:33
@Perksey Perksey mentioned this pull request Jul 5, 2019
Closed
4 tasks
Azyyyyyy
Azyyyyyy reviewed Jul 5, 2019
View reviewed changes
Copy link
Contributor

@Azyyyyyy Azyyyyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two little additions to the proposal that could be nice to have

documentation/proposals/Proposal - Input.md Show resolved Hide resolved
documentation/proposals/Proposal - Input.md Show resolved Hide resolved
@Azyyyyyy
Copy link
Contributor

Azyyyyyy commented Jul 5, 2019 •
edited
Loading

Umm would a D-Pad on a Gamepad be classed as 4 buttons because a Gamepad typically has a D-Pad?

@Perksey
Copy link
Member Author

Perksey commented Jul 5, 2019

In older versions of this proposal, I did have a DPad struct, but instead, I decided to ditch it in favour of the buttons as the same functionality can be replicated, but with less surface API. Plus, it makes it easier handling DPad buttons from the same place where you handle all your other buttons.

@Azyyyyyy
Copy link
Contributor

Azyyyyyy commented Jul 5, 2019 •
edited
Loading

Ok, if someone really wanted it they could always make a extension. Got my approval.

devvoid
devvoid reviewed Jul 5, 2019
View reviewed changes
Copy link
Contributor

@devvoid devvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I'm curious about, otherwise this looks good to me.

documentation/proposals/Proposal - Input.md Show resolved Hide resolved
@Perksey Perksey merged commit 9a1abf4 into dotnet:master Jul 5, 2019
@Perksey Perksey deleted the input-prop branch July 5, 2019 19:31
silkdotnet pushed a commit that referenced this pull request Mar 21, 2024
@dotnet-bot
New binaries for Vulkan Loader on Linux 6.5.0-1016-azure #16~22.04.1-…
93c07f2 
…Ubuntu SMP Fri Feb 16 15:42:02 UTC 2024
silkdotnet pushed a commit that referenced this pull request Mar 21, 2024
@dotnet-bot
New binaries for Wgpu on Linux 6.5.0-1016-azure #16~22.04.1-Ubuntu SM…
b34cec9 
…P Fri Feb 16 15:42:02 UTC 2024
silkdotnet pushed a commit that referenced this pull request Mar 21, 2024
@dotnet-bot
New binaries for SPIRV-Reflect on Linux 6.5.0-1016-azure #16~22.04.1-…
c7b23a5 
…Ubuntu SMP Fri Feb 16 15:42:02 UTC 2024
silkdotnet pushed a commit that referenced this pull request Mar 21, 2024
@dotnet-bot
New binaries for SDL2 on Linux 6.5.0-1016-azure #16~22.04.1-Ubuntu SM…
df81248 
…P Fri Feb 16 15:42:02 UTC 2024
silkdotnet pushed a commit that referenced this pull request Mar 24, 2024
@dotnet-bot
New binaries for DXVK on Linux 6.5.0-1016-azure #16~22.04.1-Ubuntu SM…
643ce64 
…P Fri Feb 16 15:42:02 UTC 2024
silkdotnet pushed a commit that referenced this pull request Mar 24, 2024
@dotnet-bot
New binaries for SPIRV-Cross on Linux 6.5.0-1016-azure #16~22.04.1-Ub…
049a301 
…untu SMP Fri Feb 16 15:42:02 UTC 2024
silkdotnet pushed a commit that referenced this pull request Mar 24, 2024
@dotnet-bot
New binaries for GLFW on Linux 6.5.0-1016-azure #16~22.04.1-Ubuntu SM…
78e522d 
…P Fri Feb 16 15:42:02 UTC 2024
silkdotnet pushed a commit that referenced this pull request Mar 24, 2024
@dotnet-bot
New binaries for Shaderc on Linux 6.5.0-1016-azure #16~22.04.1-Ubuntu…
11340ee 
… SMP Fri Feb 16 15:42:02 UTC 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devvoid devvoid devvoid left review comments

@Azyyyyyy Azyyyyyy Azyyyyyy approved these changes

Assignees

@Perksey Perksey

@Azyyyyyy Azyyyyyy

Labels
area-Input proposal
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Perksey @Azyyyyyy @devvoid