Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | NRE on assigning null to SqlConnectionStringBuilder.Encrypt #1778

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

DavoudEshtehari
Copy link
Contributor

Null Reference Exception with SqlConnectionStringBuilder.Encrypt = null.

@DavoudEshtehari DavoudEshtehari added the 🐛 Bug! Issues that are bugs in the drivers we maintain. label Sep 27, 2022
@DavoudEshtehari DavoudEshtehari added this to the 5.1.0-preview1 milestone Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 71.37% // Head: 71.39% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (7c56cb2) compared to base (4dafe91).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
+ Coverage   71.37%   71.39%   +0.02%     
==========================================
  Files         293      293              
  Lines       61376    61382       +6     
==========================================
+ Hits        43808    43826      +18     
+ Misses      17568    17556      -12     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 75.01% <100.00%> (+0.02%) ⬆️
netfx 69.22% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/Data/ProviderBase/DbConnectionPool.NetCoreApp.cs 75.00% <ø> (-6.82%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.19% <100.00%> (-0.48%) ⬇️
...osoft/Data/SqlClient/SqlConnectionEncryptOption.cs 93.10% <100.00%> (+6.73%) ⬆️
...osoft/Data/SqlClient/SqlConnectionStringBuilder.cs 88.60% <100.00%> (+0.01%) ⬆️
...crosoft/Data/ProviderBase/DbReferenceCollection.cs 92.63% <0.00%> (-3.16%) ⬇️
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs 68.85% <0.00%> (-0.82%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 72.88% <0.00%> (-0.40%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.57% <0.00%> (ø)
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.98% <0.00%> (+0.07%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Issues that are bugs in the drivers we maintain.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants