Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests | Skip unsupported platform x86 test and bump up Microsoft.NET.Test.Sdk version #1890

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

DavoudEshtehari
Copy link
Contributor

No description provided.

@DavoudEshtehari DavoudEshtehari added the Area\Tests Issues that are targeted to tests or test projects label Jan 17, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.1.0 milestone Jan 17, 2023
@DavoudEshtehari DavoudEshtehari changed the title Tests | Skip unsupported platform x86 and bump up Microsoft.NET.Test.Sdk version Tests | Skip unsupported platform x86 test and bump up Microsoft.NET.Test.Sdk version Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 69.90% // Head: 69.90% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e89c5cf) compared to base (8e9f3c0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1890   +/-   ##
=======================================
  Coverage   69.90%   69.90%           
=======================================
  Files         292      292           
  Lines       61732    61732           
=======================================
+ Hits        43151    43155    +4     
+ Misses      18581    18577    -4     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.08% <ø> (ø)
netfx 67.97% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs 68.85% <0.00%> (-0.82%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.19% <0.00%> (-0.67%) ⬇️
...SqlClient/src/Microsoft/Data/SqlClient/TdsEnums.cs 95.91% <0.00%> (-0.35%) ⬇️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 73.39% <0.00%> (-0.09%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 44.37% <0.00%> (+0.08%) ⬆️
...c/Microsoft/Data/Interop/SNINativeMethodWrapper.cs 76.44% <0.00%> (+1.00%) ⬆️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 64.94% <0.00%> (+2.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavoudEshtehari DavoudEshtehari merged commit 8cb5913 into dotnet:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants