This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
Adds support for reading a10:updated elements in RSS 2.0 feeds #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #34
I need some feedback on this PR. It fully supports reading
<a10:updated>
elements but theEcho
test is failing because theRssFeedWriter
does not write anything forSyndicationItem.LastUpdatedTime
.I started to implement writing the updated time, but it's tricky because the
a10
namespace would ideally be declared in the<rss>
element, but we don't know when writing it whether we have any items that require that namespace. Here's some options:a10
namespace when writing RSS feeds whether we need it or not.attributes
collection when constructing the writer or though some other property or constructor flag. Then throw if we encounter an updated time that requires the namespace but it wasn't specified.<updated>
element directly instead of on the parent<rss>
element which could get really noisy.Thoughts?