Support for basic THFile operations. #54
Conversation
NiklasGustafsson
requested review from
migueldeicaza,
markusweimer and
interesaaat
|
Odd -- it's not re-running the checks. |
| /// <summary> | ||
| /// The storage class provides a mechanism to access the underlying data representation for memory files. | ||
| /// </summary> | ||
| public class CharStorage : IDisposable { |
There was a problem hiding this comment.
So my understanding is that CharStorage is used here while the other type of storages are used to back a tensor. Is this correct?
There was a problem hiding this comment.
Yes, that's what the C interface is using for memory files.
There was a problem hiding this comment.
Storages now are in 2 different files. Should we do as in Torch where all storages classes are in one file? This can be solved in a separate PR (related to #50?)
TorchSharp/TorchSharp.csproj
Outdated
| </Compile> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Service Include="{508349b6-6b84-4df5-91f0-309beebad82d}" /> |
There was a problem hiding this comment.
I think we can remove this.
There was a problem hiding this comment.
The Service tag?
There was a problem hiding this comment.
I don't know why it keeps coming back. I've removed it before.
|
This seems to be using two different set of indentation styles in P/Invoke declarations. |
|
@migueldeicaza, are you referring to the placement of the [DllImport] attribute? The one-line format came about because I copied code from C, and then did a global replace. The latest update should have this addressed, with two lines for each declaration. If you're referring to something else, please explain. |
| /// <summary> | ||
| /// The storage class provides a mechanism to access the underlying data representation for memory files. | ||
| /// </summary> | ||
| public class CharStorage : IDisposable { |
There was a problem hiding this comment.
Storages now are in 2 different files. Should we do as in Torch where all storages classes are in one file? This can be solved in a separate PR (related to #50?)
|
Are we good with this PR now? |
With this PR, support for MemoryFile and DiskFile is introduced.