Make $(AndroidLinkResources) able to be the default for MAUI projects
#7194
Comments
jonathanpeppers
added
the
Area: App+Library Build
|
I was hitting the same problem today (not using a 3rd party library) when subclassing a View and using Would appreciate if a fix could be found |
|
@tipa can you share the error message you got? Probably a crash at runtime? |
|
With the demo project attached I first get this exception (only when enabling all exceptions in the VS Exception Settings Window): When I then click "Continue" in the debugger I get this exception: They are crashes at runtime, yes |
) Fixes: #7194 Context: dotnet/maui#7038 The initial version of `$(AndroidLinkResources)` (9e6ce03) was too broad in its removal of Resource classes and fields. Certain fields such as `Styleable` arrays were not called using the IL `stsfld` opcode. As a result they could not be easily replaced with constant usage. However, the linker removed *all* the fields from the `Resource` nested types. This would result in the following error at runtime: System.BadImageFormatException: 'Could not resolve field token 0x0400000b' This was because the `int[]` fields were removed as part of the linking process. Fix this by leaving the `int[]` fields in the `Resource` nested types instead of removing them. We can still remove all the other `int` fields. We now also need to fix up the `Resource` nested type constructors to replace the `int` field access with the constant values like we do for the rest of the app. This was not required previously because these constructors were removed, but now we have to keep them because the static array initialization takes place in these constructors.
ghost
locked as resolved and limited conversation to collaborators
Android application type
Android for .NET (net6.0-android, etc.)
Affected platform version
.NET 7
Description
Context: dotnet/maui#7038
We found some Telerik and/or other vendor libraries would fail due to this code in SkiaSharp:
https://github.com/mono/SkiaSharp/blob/4a687a87b86f127ccc23116ee410dcb5df8fca63/source/SkiaSharp.Views/SkiaSharp.Views.Android/SKCanvasView.cs#L48-L61
So if we don't finish #6427 for .NET 7, we could consider:
SKCanvasViewso it doesn't use aStyleable int[].AndroidLinkResourceslinker step encounters aint[]AndroidLinkResources=trueby default for MAUI projectsSteps to Reproduce
SKCanvasViewin a project-c Release -p:AndroidLinkResources=trueDid you find any workaround?
Don't use
$(AndroidLinkResources)Relevant log output
No response
The text was updated successfully, but these errors were encountered: