[libmonodroid] Enable GC bridge on desktop Java. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is still some weird GC behavior that happens only on desktop. It seems like calling `System.gc()` there doesn't properly collect as much references as it could which mean that Java/managed peer pairs are kept around longer than they should be. Nonetheless, having this in still means we have a much better story for the designer and XF Previewer memory wise.
|
Hi @garuma, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
radical
added a commit
that referenced
this pull request
May 8, 2018
…oid/a438c473 [Xamarin.Android.Tools.bytecode] Add JavaDoc importing
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jul 21, 2022
Changes: mono/opentk@50128f7...daa9b2d * mono/opentk@daa9b2d5: [nuget] use $(PackageLicenseExpression), not $(PackageLicenseUrl) (dotnet#35) * mono/opentk@351eb656: [ci] Use new EO compliant build pools (dotnet#33) * mono/opentk@95ab20b1: Try to fix DllNotFoundException under .net 6 (dotnet#32) * mono/opentk@3de39a40: Merge pull request dotnet#30 from dellis1972/proguard * mono/opentk@79ea8095: rework * mono/opentk@3311a8ac: Add Proguard config support
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jul 22, 2022
Changes: mono/opentk@50128f7...daa9b2d * mono/opentk@daa9b2d5: [nuget] use $(PackageLicenseExpression), not $(PackageLicenseUrl) (dotnet#35) * mono/opentk@351eb656: [ci] Use new EO compliant build pools (dotnet#33) * mono/opentk@95ab20b1: Try to fix DllNotFoundException under .net 6 (dotnet#32) * mono/opentk@3de39a40: Merge pull request dotnet#30 from dellis1972/proguard * mono/opentk@79ea8095: rework * mono/opentk@3311a8ac: Add Proguard config support
jonpryor
added a commit
that referenced
this pull request
Jul 26, 2022
Changes: mono/opentk@50128f7...daa9b2d * mono/opentk@daa9b2d5: [nuget] use $(PackageLicenseExpression), not $(PackageLicenseUrl) (#35) * mono/opentk@351eb656: [ci] Use new EO compliant build pools (#33) * mono/opentk@95ab20b1: Try to fix DllNotFoundException under .net 6 (#32) * mono/opentk@3de39a40: Merge pull request #30 from dellis1972/proguard * mono/opentk@79ea8095: rework * mono/opentk@3311a8ac: Add Proguard config support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still some weird GC behavior that happens only on desktop. It seems like calling
System.gc()there doesn't properly collect as much references as it could which mean that Java/managed peer pairs are kept around longer than they should be.Nonetheless, having this in still means we have a much better story for the designer and XF Previewer memory wise.