[Xamarin.Android.Build.Tasks] fixup invalid $(AndroidDexTool) #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#4439 If you build a project with `AndroidDexTool=invalid`, you end up with an APK file that is missing a `classes.dex`. We don't emit an error, and you won't actually know anything is wrong until going to install the APK. If someone did this on accident, I think we can just default `AndroidDexTool=d8` *unless* it is set to `dx`. I updated a test for this.
dellis1972
approved these changes
Apr 9, 2020
jonpryor
pushed a commit
that referenced
this pull request
Apr 17, 2020
Fixes: #4439 If you build a project with `AndroidDexTool=invalid`, you end up with an APK file that is missing a `classes.dex`. We don't emit an error, and you won't actually know anything is wrong until going to install the APK. If someone did this on accident, I think we can just default `AndroidDexTool=d8` *unless* it is set to `dx`. I updated a test for this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4439
If you build a project with
AndroidDexTool=invalid, you end up withan APK file that is missing a
classes.dex. We don't emit an error,and you won't actually know anything is wrong until going to install
the APK.
If someone did this on accident, I think we can just default
AndroidDexTool=d8unless it is set todx.I updated a test for this.