-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate LLVM IR instead of native assembler code #6853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
requested review from
jonpryor,
dellis1972 and
jonathanpeppers
as code owners
March 25, 2022 11:52
grendello
requested review from
pjcollins,
dellis1972,
jonathanpeppers and
jonpryor
and removed request for
jonpryor,
dellis1972 and
jonathanpeppers
March 25, 2022 11:52
jonathanpeppers
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything in the src/Xamarin.Android.Build.Tasks
folder looks OK to me. 👍
dellis1972
approved these changes
Mar 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of continuing to generate native assembler code, as we've been doing for a while now, switch to
generating LLVM IR sources. This has the advantage that LLVM takes
care for us of generating valid native assembler code, making sure it adheres to all the ABI requirements
of the target platform. It also makes it easier, in future, to generate actual executable code instead of
just data as we do now.
Once the LLVM IR is generated, the
llc
utility from LLVM is used to generate the actual native assemblercode. LLVM IR files are larger than the native assembler ones we've been generating so far, because of the
language's verbosity, but we generate less of them.
This PR covers generation of compressed assemblies, application environment and typemap sources.