[tests] disable $(_FastDeploymentDiagnosticLogging) in PerformanceTest
#7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6595850&view=ms.vss-test-web.build-test-results-tab&runId=51752272&resultId=100026&paneView=debug Frequently `Install_CSharp_Change` fails with: Exceeded expected time of 4500ms, actual 4671.203ms Reviewing the `.binlog` the `<FastDeploy/>` task shows up: Top 10 most expensive tasks GenerateJavaStubs = 1.304 s _GenerateJavaStubs = 1.304 s FastDeploy = 498 ms _Upload = 498 ms `<FastDeploy/>` is logging "lots of stuff" due to `$(_FastDeploymentDiagnosticLogging)`: FastDeploy Parameters DiagnosticLogging = True ... // Hundreds of lines of: xamarin.find: Ignoring line 'DEBUG: ./UnnamedProject.dll size:1661286176390 mtime:6144 tv_sec:1661286176 tv_nsec:390000'. Line is incorrectly formatted. This was added in 7b51fd1, to help debug other issues. Let's turn off this setting on `PerformanceTest`, as we're looking to measure how fast build & deploy is. Less log messages should help.
dellis1972
approved these changes
Aug 24, 2022
|
It looks like this change worked, reduced the logging:
But I'm not sure it improved the time? Going to merge this, as it shouldn't make it any worse. I will probably need to raise the times for main. |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 26, 2022
* main: [tests] disable `$(_FastDeploymentDiagnosticLogging)` in PerformanceTest (dotnet#7307)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 26, 2022
* mm-runtime: [tests] disable `$(_FastDeploymentDiagnosticLogging)` in PerformanceTest (dotnet#7307)
jonathanpeppers
added a commit
that referenced
this pull request
Aug 29, 2022
…est (#7307) Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6595850&view=ms.vss-test-web.build-test-results-tab&runId=51752272&resultId=100026&paneView=debug Frequently `Install_CSharp_Change` fails with: Exceeded expected time of 4500ms, actual 4671.203ms Reviewing the `.binlog` the `<FastDeploy/>` task shows up: Top 10 most expensive tasks GenerateJavaStubs = 1.304 s _GenerateJavaStubs = 1.304 s FastDeploy = 498 ms _Upload = 498 ms `<FastDeploy/>` is logging "lots of stuff" due to `$(_FastDeploymentDiagnosticLogging)`: FastDeploy Parameters DiagnosticLogging = True ... // Hundreds of lines of: xamarin.find: Ignoring line 'DEBUG: ./UnnamedProject.dll size:1661286176390 mtime:6144 tv_sec:1661286176 tv_nsec:390000'. Line is incorrectly formatted. This was added in 7b51fd1, to help debug other issues. Let's turn off this setting on `PerformanceTest`, as we're looking to measure how fast build & deploy is. Less log messages should help.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6595850&view=ms.vss-test-web.build-test-results-tab&runId=51752272&resultId=100026&paneView=debug
Frequently
Install_CSharp_Changefails with:Reviewing the
.binlogthe<FastDeploy/>task shows up:<FastDeploy/>is logging "lots of stuff" due to$(_FastDeploymentDiagnosticLogging):This was added in 7b51fd1, to help debug other issues.
Let's turn off this setting on
PerformanceTest, as we're looking tomeasure how fast build & deploy is. Less log messages should help.