[One .NET] fix dotnet run -c Release
#7341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/xamarin#26 The following does not work as expected: dotnet new android dotnet run -c Release You end up with a `Debug` app in this case. The way we implemented `dotnet run` was to make `$(RunCommand)` and `$(RunArguments)` invoke `dotnet build -t:Run`. We were losing the `$(Configuration)` value in this example.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 6, 2022
* main: [FabricBot] Add `possibly-stale` GitHub label for closing old issues (dotnet#7343) Don't use Dictionary<K,V> to avoid duplicate value exception (dotnet#7340) [One .NET] fix `dotnet run -c Release` (dotnet#7341)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 6, 2022
* mm-runtime: [FabricBot] Add `possibly-stale` GitHub label for closing old issues (dotnet#7343) Don't use Dictionary<K,V> to avoid duplicate value exception (dotnet#7340) [One .NET] fix `dotnet run -c Release` (dotnet#7341)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 6, 2022
* mm-cleanup-and-enable: [FabricBot] Add `possibly-stale` GitHub label for closing old issues (dotnet#7343) Don't use Dictionary<K,V> to avoid duplicate value exception (dotnet#7340) [One .NET] fix `dotnet run -c Release` (dotnet#7341) Make AOT work (with trimming) Fix Debug mode and Release w/o marshal methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/xamarin#26
The following does not work as expected:
You end up with a
Debugapp in this case.The way we implemented
dotnet runwas to make$(RunCommand)and$(RunArguments)invokedotnet build -t:Run.We were losing the
$(Configuration)value in this example.