Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[One .NET] fix dotnet run -c Release #7341

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

jonathanpeppers
Copy link
Member

Context: dotnet/xamarin#26

The following does not work as expected:

dotnet new android
dotnet run -c Release

You end up with a Debug app in this case.

The way we implemented dotnet run was to make $(RunCommand) and
$(RunArguments) invoke dotnet build -t:Run.

We were losing the $(Configuration) value in this example.

Context: dotnet/xamarin#26

The following does not work as expected:

    dotnet new android
    dotnet run -c Release

You end up with a `Debug` app in this case.

The way we implemented `dotnet run` was to make `$(RunCommand)` and
`$(RunArguments)` invoke `dotnet build -t:Run`.

We were losing the `$(Configuration)` value in this example.
@jonpryor jonpryor merged commit beaef75 into dotnet:main Sep 6, 2022
@jonathanpeppers jonathanpeppers deleted the dotnet-run-release branch September 6, 2022 19:06
grendello added a commit to grendello/xamarin-android that referenced this pull request Sep 6, 2022
* main:
  [FabricBot] Add `possibly-stale` GitHub label for closing old issues (dotnet#7343)
  Don't use Dictionary<K,V> to avoid duplicate value exception (dotnet#7340)
  [One .NET] fix `dotnet run -c Release` (dotnet#7341)
grendello added a commit to grendello/xamarin-android that referenced this pull request Sep 6, 2022
* mm-runtime:
  [FabricBot] Add `possibly-stale` GitHub label for closing old issues (dotnet#7343)
  Don't use Dictionary<K,V> to avoid duplicate value exception (dotnet#7340)
  [One .NET] fix `dotnet run -c Release` (dotnet#7341)
grendello added a commit to grendello/xamarin-android that referenced this pull request Sep 6, 2022
* mm-cleanup-and-enable:
  [FabricBot] Add `possibly-stale` GitHub label for closing old issues (dotnet#7343)
  Don't use Dictionary<K,V> to avoid duplicate value exception (dotnet#7340)
  [One .NET] fix `dotnet run -c Release` (dotnet#7341)
  Make AOT work (with trimming)
  Fix Debug mode and Release w/o marshal methods
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants