-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/installer #8366
[main] Update dependencies from dotnet/installer #8366
Conversation
…230921.4 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23471.4 Dependency coherency updates Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil From Version 8.0.0-rc.2.23466.4 -> To Version 8.0.0-rc.1.23414.4 (parent: Microsoft.Dotnet.Sdk.Internal
…230924.1 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23474.1 Dependency coherency updates Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil From Version 8.0.0-rc.2.23466.4 -> To Version 8.0.0-rc.1.23414.4 (parent: Microsoft.Dotnet.Sdk.Internal
…230926.6 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23476.6 Dependency coherency updates Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil From Version 8.0.0-rc.2.23466.4 -> To Version 8.0.0-rc.1.23414.4 (parent: Microsoft.Dotnet.Sdk.Internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably shouldn't merge this one until we get the fix for:
Mono.Android.NET_Tests, SystemTests.AppContextTests.TestPrivateSwitches("System.Diagnostics.Metrics.Meter, System.Diagnostics.DiagnosticSource","<IsSupported>k__BackingField",False) / Release
I think it doesn't have the latest dotnet/runtime/main with my change for this.
…230929.5 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23479.5 Dependency coherency updates Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil From Version 8.0.0-rc.2.23466.4 -> To Version 8.0.0-rc.1.23414.4 (parent: Microsoft.Dotnet.Sdk.Internal
…231004.14 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23504.14
…231012.15 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23512.15
…231017.3 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23517.3
…231022.3 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23522.3
…231024.3 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23524.3
…231029.1 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23529.1
Then I updated to the latest build from: https://maestro-prod.westus2.cloudapp.azure.com/3884/https:%2F%2Fgithub.com%2Fdotnet%2Finstaller/latest/graph > darc update-dependencies --id 200002 Looking up build with BAR id 200002 Updating 'Microsoft.Dotnet.Sdk.Internal': '9.0.100-alpha.1.23529.1' => '9.0.100-alpha.1.23552.5' (from build '20231102.5' of 'https://github.com/dotnet/installer') Checking for coherency updates... Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made. Updating 'Microsoft.NETCore.App.Ref': '8.0.0-rc.1.23414.4' => '9.0.0-alpha.1.23552.1' to ensure coherency with Microsoft.Dotnet.Sdk.Internal@9.0.100-alpha.1.23552.5 Updating 'Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport': '8.0.0-rc.1.23411.2' => '9.0.0-alpha.1.23530.1' to ensure coherency with Microsoft.NETCore.App.Ref@8.0.0-rc.1.23414.4 Updating 'Microsoft.NET.ILLink.Tasks': '8.0.0-rc.1.23414.4' => '9.0.0-alpha.1.23552.1' to ensure coherency with Microsoft.Dotnet.Sdk.Internal@9.0.100-alpha.1.23552.5 Updating 'Microsoft.DotNet.Cecil': '0.11.4-alpha.23407.2' => '0.11.4-alpha.23509.2' to ensure coherency with Microsoft.NET.ILLink.Tasks@8.0.0-rc.1.23414.4 Local dependencies updated based on build with BAR id 200002 (20231102.5 from https://github.com/dotnet/installer@main)
This reverts commit 1b728dd.
…231104.1 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23554.1
Context: dotnet/android#8366 dotnet/android#8366 is attempting to build xamarin-android against .NET 9 previews, and currently fails: (Restore target) -> tests/MSBuildDeviceIntegration/MSBuildDeviceIntegration.csproj : error NU1605: Warning As Error: Detected package downgrade: Microsoft.Build.Framework from 17.5.0 to 17.3.2. Reference the package directly from the project to select a different version. tests/MSBuildDeviceIntegration/MSBuildDeviceIntegration.csproj : error NU1605: MSBuildDeviceIntegration -> MSBuild.StructuredLogger 2.2.100 -> doh (>= 17.5.0) tests/MSBuildDeviceIntegration/MSBuildDeviceIntegration.csproj : error NU1605: MSBuildDeviceIntegration -> Microsoft.Build.Framework (>= 17.3.2) tests/MSBuildDeviceIntegration/MSBuildDeviceIntegration.csproj : error NU1605: Warning As Error: Detected package downgrade: Microsoft.Build.Utilities.Core from 17.5.0 to 17.3.2. Reference the package directly from the project to select a different version. tests/MSBuildDeviceIntegration/MSBuildDeviceIntegration.csproj : error NU1605: MSBuildDeviceIntegration -> MSBuild.StructuredLogger 2.2.100 -> Microsoft.Build.Utilities.Core (>= 17.5.0) tests/MSBuildDeviceIntegration/MSBuildDeviceIntegration.csproj : error NU1605: MSBuildDeviceIntegration -> Microsoft.Build.Utilities.Core (>= 17.3.2) We need to update `MSBuild.StructuredLogger` package to be able to move to .NET 9, as the `.binlog` file format changed in .NET 9. The newer `MSBuild.StructuredLogger` package, in turn, requires a newer `Microsoft.Build.Framework` package version, which is controlled here. Update the `$(MSBuildPackageReferenceVersion)` MSBuild property so that (1) it can now be overridden, which would allow version updates in the future without requiring submodule updates, and (2) update the the default value to 17.6.3. I fear that if we move to 17.8.3, we may potentially break other repos. VS 2022 17.6 is an LTS release that feels "safe", is new enough to solve the issue, and hopefully won't break anyone? Additionally, update the `System.Security.Cryptography.Xml` package so that it now uses an overridable `$(SystemSecurityCryptographyXmlVersion)` MSBuild property, which defaults to 7.0.1, in order to fix this build error: src\Microsoft.Android.Build.BaseTasks\Microsoft.Android.Build.BaseTasks.csproj : error NU1605: Detected package downgrade: System.Security.Cryptography.Xml from 7.0.1 to 6.0.1. Reference the package directly from the project to select a different version. src\Microsoft.Android.Build.BaseTasks\Microsoft.Android.Build.BaseTasks.csproj : error NU1605: Microsoft.Android.Build.BaseTasks -> Microsoft.Build.Tasks.Core 17.6.3 -> System.Security.Cryptography.Xml (>= 7.0.1) src\Microsoft.Android.Build.BaseTasks\Microsoft.Android.Build.BaseTasks.csproj : error NU1605: Microsoft.Android.Build.BaseTasks -> System.Security.Cryptography.Xml (>= 6.0.1) tests\Microsoft.Android.Build.BaseTasks-Tests\Microsoft.Android.Build.BaseTasks-Tests.csproj : error NU1605: Detected package downgrade: System.Security.Cryptography.Xml from 7.0.1 to 6.0.1. Reference the package directly from the project to select a different version. tests\Microsoft.Android.Build.BaseTasks-Tests\Microsoft.Android.Build.BaseTasks-Tests.csproj : error NU1605: Microsoft.Android.Build.BaseTasks-Tests -> Microsoft.Build.Tasks.Core 17.6.3 -> System.Security.Cryptography.Xml (>= 7.0.1) tests\Microsoft.Android.Build.BaseTasks-Tests\Microsoft.Android.Build.BaseTasks-Tests.csproj : error NU1605: Microsoft.Android.Build.BaseTasks-Tests -> System.Security.Cryptography.Xml (>= 6.0.1)
Context: #8366 Context: dotnet/sdk@d21e6bf Rolf introduced an "escape hatch" in the .NET 9 SDK for emitting a build warning for a case that doesn't make sense on mobile. All mobile apps are self-contained, and we define RIDs by default, so the error is not needed. It appears than when building `net8.0-android` apps on the .NET 9 SDK, we will also need to silence this warning. This property should not have any effect in the stable, .NET 8 SDK. After this change goes in, we'll likely need the .NET 9 Android workload to depend on a newer .NET 8 Android workload with this change in place.
Context: #8366 Context: dotnet/sdk@d21e6bf Rolf introduced an "escape hatch" in the .NET 9 SDK for emitting a build warning for a case that doesn't make sense on mobile. All mobile apps are self-contained, and we define RIDs by default, so the error is not needed. It appears than when building `net8.0-android` apps on the .NET 9 SDK, we will also need to silence this warning. This property should not have any effect in the stable, .NET 8 SDK. After this change goes in, we'll likely need the .NET 9 Android workload to depend on a newer .NET 8 Android workload with this change in place.
Thanks for fixing the usage of |
…231203.1 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-rc.2.23468.1 -> To Version 9.0.100-alpha.1.23603.1
//FIXME: will revisit this in a future PR | ||
if (dotnetVersion == "net8.0") { | ||
Assert.Ignore ("error NETSDK1185: The Runtime Pack for FrameworkReference 'Microsoft.Android.Runtime.34.android-arm' was not available. This may be because DisableTransitiveFrameworkReferenceDownloads was set to true."); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to file an issue or issue group for things like this (and the intune test ignore) on the .NET 9 milestone to help make sure they don't get lost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I planned to just work on this one immediately after we merge this. Will probably require some trial/error.
Commit message:
|
* main: [monodroid] Add a handful of compiler options to harden code (#8551) Bump to dotnet/installer@42ace91ba7 .NET 9.0.100-alpha.1.23603.1 (#8366) [xaprepare] Track the versions of Android SDK Levels available on CI agents. (#8552)
* main: [monodroid] Add a handful of compiler options to harden code (#8551) Bump to dotnet/installer@42ace91ba7 .NET 9.0.100-alpha.1.23603.1 (#8366)
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer