Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trimming] use public $(MetricsSupport) property #9068

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[trimming] use public $(MetricsSupport) property #9068

merged 1 commit into from
Jul 1, 2024

Commits on Jul 1, 2024

  1. [trimming] use public $(MetricsSupport) property 

    Context: dotnet#9060 (comment)
Context: https://github.com/dotnet/sdk/blob/e18cfb7a09d74952d5e9c2448d31dee313e059bb/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L522-L525

In eb6397d, we introduced `$(_SystemDiagnosticsMetricsMeterIsSupported)`
to avoid a startup time regression with `HttpClient`-related code. At
the time, the public property `$(MetricsSupport)` had not been
introduced yet in the .NET SDK.

Let's use `$(MetricsSupport)` instead of the private
`$(_SystemDiagnosticsMetricsMeterIsSupported)` property.
    @jonathanpeppers
    jonathanpeppers committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0cb05a4 View commit details
    Browse the repository at this point in the history