Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package source mapping doesn't work with Maestro added feeds #3002

Open
1 of 2 tasks
ViktorHofer opened this issue Oct 24, 2023 · 2 comments
Open
1 of 2 tasks

Package source mapping doesn't work with Maestro added feeds #3002

ViktorHofer opened this issue Oct 24, 2023 · 2 comments

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 24, 2023

  • This issue is blocking
  • This issue is causing unreasonable pain

Came up in dotnet/format#1987

When using NuGet Central Package Management with more than one NuGet feed, package source mapping must be used: https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management#warning-when-using-multiple-package-sources

Unfortunately, Maestro (?) doesn't support this model as it dynamically adds feeds when producing stabilized package versions (in RTM and servicing mode). Therefore, repositories that started using CPM had to add a NoWarn=NU1507 setting to make CPM work.

I see package source mapping as a useful feature that our infrastructure shouldn't block using. Here's some more history on this: dotnet/arcade#9885 (comment)

cc @mmitche @ChadNedzlek

@riarenas
Copy link
Member

Moving this issue to arcade-services where the Maestro team can take a look.

@richlander
Copy link
Member

Maestro could add a package source mapping when it adds a new source.

Using the referenced PR, this would look like:

    <packageSource key="darc-pub-dotnet-runtime-488a8a3">
      <package pattern="System.*" />
      <package pattern="Microsoft.*" />
    </packageSource>

That seems pretty reasonable while enabling the broad team to adopt PSM. The value of PSM is the additional transparency with dotnet-public where we don't use wildcards.

https://github.com/dotnet/format/pull/1987/files#diff-9c5952957709545aad811b400e7e516eebade1e44fc4fbc23203403ffeb92c34L40-L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants