Upgrade Arcade to .NET 9 SDK and TFM #14279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds on top of the work from last year: dotnet#12096 Installer version: 9.0.100-alpha.1.23612.1 AspNetCore runtime version: 9.0.0-alpha.1.23577.26
ViktorHofer
force-pushed
the
UpdateTo90SDKAndTfm
branch
from
c27ea76
to
364ccc2
Compare
mthalman
reviewed
Dec 12, 2023
mthalman
previously approved these changes
Dec 12, 2023
ViktorHofer
force-pushed
the
UpdateTo90SDKAndTfm
branch
from
3e6214b
to
7375aa4
Compare
Closed
…otations. We can't get everything right, but we can do the best we can. Suppress warnings in a few places and use DynamicDependency where necessary to preserve existing behavior.
|
Now blocked on #14172 |
mmitche
approved these changes
Dec 13, 2023
mthalman
reviewed
Dec 13, 2023
There was a problem hiding this comment.
This will require some patch removal when flowing to installer: https://github.com/dotnet/installer/tree/main/src/SourceBuild/patches/arcade
| @@ -2,7 +2,7 @@ | |||
| <Project> | |||
|
|
|||
| <PropertyGroup> | |||
| <ApiCompatAssembly Condition="'$(MSBuildRuntimeType)' == 'core'">$(MSBuildThisFileDirectory)..\tools\net8.0\Microsoft.DotNet.ApiCompat.dll</ApiCompatAssembly> | |||
| <ApiCompatAssembly Condition="'$(MSBuildRuntimeType)' == 'core'">$(MSBuildThisFileDirectory)..\tools\net9.0\Microsoft.DotNet.ApiCompat.dll</ApiCompatAssembly> | |||
There was a problem hiding this comment.
Any reason why these kinds of paths can't use $(NetCurrent)?
There was a problem hiding this comment.
I think these end imported from the NuGet package itself, where NetCurrent may not already be defined?
There was a problem hiding this comment.
This file is evaluated in the consuming project, in a different repository than Arcade so the NetCurrent property won't be available.
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of the work from last year: #12096
Installer version: 9.0.100-alpha.1.23613.1
AspNetCore runtime version: 9.0.0-alpha.1.23612.4
Changes were performed via search and replace...