Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Replace SAS with service connection for source index stage 1 upload #14886

Merged
merged 2 commits into from
Jun 26, 2024
Merged

[release/6.0] Replace SAS with service connection for source index stage 1 upload #14886

merged 2 commits into from
Jun 26, 2024

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jun 21, 2024

Manual backport of #14750 to release/6.0. Unblocks arcade official build.

To double check:

@directhex @mmitche
Use Service Connection instead of SAS for source index stage 1 upload (…
8c4965f 
…dotnet#14766)

Manual backport of dotnet#14750 to release/8.0

Needed for Spring Grove.

The only repo using Arcade 8.0 but publishing to Source Index is maintenance-packages.
@mmitche mmitche requested review from directhex and dougbu June 21, 2024 22:00
@mmitche
Copy link
Member Author

mmitche commented Jun 21, 2024

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2479484&view=results

@mmitche mmitche enabled auto-merge (squash) June 21, 2024 22:24
This was referenced Jun 22, 2024
Open
Open
@mmitche mmitche mentioned this pull request Jun 25, 2024
Closed
@mmitche mmitche requested a review from premun June 25, 2024 19:36
@premun premun changed the title Use Service Connection instead of SAS for source index stage 1 upload [release/6.0] Replace SAS with service connection for source index stage 1 upload Jun 26, 2024
@mmitche mmitche merged commit 1844d81 into dotnet:release/6.0 Jun 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premun premun premun approved these changes

@directhex directhex Awaiting requested review from directhex

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmitche @premun @directhex