Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat month as decimal instead of octal #14985

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Aug 1, 2024

With - we make sure to drop the leading 0 that is interpreted as octal number in calculations when running as a pure Unix shell script (which we use in mono component build).

@am11 am11 changed the title Treat month has deciman insteal of octal Treat month as deciman instead of octal Aug 1, 2024
@am11 am11 changed the title Treat month as deciman instead of octal Treat month as decimal instead of octal Aug 1, 2024
@akoeplinger akoeplinger merged commit a3dae8d into dotnet:main Aug 1, 2024
11 checks passed
@am11 am11 deleted the patch-13 branch August 1, 2024 08:49
@am11
Copy link
Member Author

am11 commented Aug 1, 2024

@akoeplinger should we manually port this patch or wait for arcade sync?

@akoeplinger
Copy link
Member

I merged dotnet/runtime#105785 to unblock the build, it will get overwritten with the next arcade update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants