-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SymUploader removal stage 1: Remove usage of symuploader in Feed task #15012
SymUploader removal stage 1: Remove usage of symuploader in Feed task #15012
Conversation
82e3a37
to
edbe691
Compare
- Use polly for resilience on symbol.exe download. - Fix some redirect and potential stream issues - Add a new SymbolPromotionHelper to help with symbol promotion
edbe691
to
f6fd117
Compare
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Internal.SymbolHelper/SymbolUploadHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Internal.SymbolHelper/SymbolUploadHelper.cs
Outdated
Show resolved
Hide resolved
81ddbc9
to
da0bbbe
Compare
Arcade build consuming arcade build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2520500&view=results Used a random runtime build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2520038&view=results |
The failures are related to token issues - I am using a PAT as a token and I didn't realize that the "Bearer" scheme won't work for that. I've changed to always using basic with both PAT and access token for the client download. |
Arcade build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2521540&view=results New runtime promotion with that arcade: https://dev.azure.com/dnceng/internal/_build/results?buildId=2521571 |
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Show resolved
Hide resolved
Contributes to #14501 |
That worked e2e. And so does one with the special indexing: https://dev.azure.com/dnceng/internal/_build/results?buildId=2521600&view=results. |
To leave a cookie behind about perf issues:
|
The arcade build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2522063&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=74531eb2-9b39-5603-839e-94e3ba212b65 passes. Was just having a warning from missing my last commit. |
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/Microsoft.DotNet.Build.Tasks.Feed.csproj
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Internal.SymbolHelper/SymbolPromotionHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Internal.SymbolHelper/SymbolPublisherOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
578db0c
to
3c409d7
Compare
3c409d7
to
0d7ff45
Compare
|
There was a failure but there's nothing in the console logs and the binlog isn't uploaded. rerun with binlog collection https://dev.azure.com/dnceng/internal/_build/results?buildId=2525547 |
Promotion of arcade with latest bits https://dev.azure.com/dnceng/internal/_build/results?buildId=2525549 |
Both of them ran clean... To make sure, one last runtime run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2525650 |
Failed! |
Validation with builds happening manually currently.
A few things have changed as breaking changes: