Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider merging Project Logs and Container Logs pages #176

Closed
JamesNK opened this issue Sep 18, 2023 · 10 comments · Fixed by #1034
Closed

Consider merging Project Logs and Container Logs pages #176

JamesNK opened this issue Sep 18, 2023 · 10 comments · Fixed by #1034
Assignees

Comments

@JamesNK
Copy link
Member

JamesNK commented Sep 18, 2023

We could simplify the sidebar menu by merging Project Logs and Container Logs pages under a "Console Logs" page. The dropdown on the page would have a selectable list of projects and containers merged together. Future executable logs feature would also use this page.

There should be an indication of whether the selected item is a project, container, or executable.

@dbreshears dbreshears added this to the preview-4 weeks milestone Sep 18, 2023
@davidfowl
Copy link
Member

cc @leslierichardson95

@tlmii
Copy link
Member

tlmii commented Sep 29, 2023

I wonder if we should do this before (or while) doing dotnet/aspire-private-planning#682

As James alluded to, we'd probably need to do a little bit of design as to how we indicate what type the selected item is (and whether we show any other details about it - state?). Also the dropdown would look a little intimidating as just a flat list of everything together (fluent-select doesn't support optgroup)... should consider different ways that could be displayed/selected.

@leslierichardson95

@JamesNK
Copy link
Member Author

JamesNK commented Sep 29, 2023

Idea: Fluent select supports icons. Have the dropdown show both together but with different icons, e.g.

  • A project
  • B project
  • A container
  • B container

@danmoseley
Copy link
Member

Need to discuss whether we want to /can do this for preview or not.

@smitpatel
Copy link
Contributor

If we are putting this in milestone, we would need assignee for this. cc: @dbreshears
I think last we discussed that we would show menu entry in sidebar and any other merge work is post-release.

@davidfowl
Copy link
Member

I think the grouping is good enough for preview.

cc @DamianEdwards to see what he thinks.

@DamianEdwards
Copy link
Member

What we have now or some other grouping?

@JamesNK
Copy link
Member Author

JamesNK commented Oct 7, 2023

I'm still not a fan of the menu layout and separate project/container/executable pages.

IMO the menu should be something like:

  • Projects
  • Containers
  • Executables
  • Monitoring
    • Console logs (the merged logging page)
    • Structured logs
    • Traces
    • Metrics

@davidfowl
Copy link
Member

I'm not a fan either but I don't think this is critical for preview, and the recent changes make a tad bit nicer and much less work.
image

@dbreshears
Copy link
Contributor

We should address, but post-preview

@dbreshears dbreshears modified the milestones: preview-4 weeks, some time after preview Oct 9, 2023
@danmoseley danmoseley transferred this issue from another repository Oct 9, 2023
@danmoseley danmoseley removed this from the needs milestone (for GA) milestone Nov 13, 2023
This was referenced Nov 21, 2023
@kvenkatrajan kvenkatrajan added this to the preview 2 (Dec) milestone Nov 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants